-
Distributions like shared libraries because it makes life easier for system administrators. If you leave it up to each application to bundle and verify that their application works with an exact copy of scintilla, then the system administrator has to trust that each application developer is on top of the problems that can occur in scintilla. If, for instance, scintilla were to announce a...
2009-07-07 00:21:45 UTC in Scintilla
-
Thanks for testing. Let's see if I can get this right this time.
> 1) I'd really like to avoid code like this: sp->ImageDesc.Width > INT_MAX
> / sp->ImageDesc.Height.
> Please use round brackets.
Heh. Too much python makes you parenthesis lazy :-)
Fixed.
2) if (ImageSize > (SIZE_MAX / sizeof(GifPixelType)))
This should be INT_MAX, not SIZE_MAX, since ImageSize is int now...
2008-01-23 16:17:40 UTC in giflib -- A library for processing GIFs
-
abadger1999 committed patchset 39 of module giflib to the giflib -- A library for processing GIFs CVS repository, changing 1 files.
2008-01-23 16:16:13 UTC in giflib -- A library for processing GIFs
-
Thanks! Your patch looks almost perfect except that you don't want to be checking against the size of Width and Height's type but of the size of ImageSize's type.
Taking a longer look at the function, though, I see that we're passing ImageSize to another public function later so I shouldn't change the type of ImageSize to size_t. So the right thing is almost exactly your patch plus changing...
2008-01-22 19:26:36 UTC in giflib -- A library for processing GIFs
-
abadger1999 committed patchset 38 of module giflib to the giflib -- A library for processing GIFs CVS repository, changing 2 files.
2008-01-22 19:08:25 UTC in giflib -- A library for processing GIFs
-
The following patch has been applied in CVS. Are you able to test that this works?
Index: dgif_lib.c
===================================================================
RCS file: /cvsroot/giflib/giflib/lib/dgif_lib.c,v
retrieving revision 1.7
diff -u -r1.7 dgif_lib.c
--- dgif_lib.c 21 Jan 2008 23:23:23 -0000 1.7
+++ dgif_lib.c 22 Jan 2008 00:31:15 -0000
@@ -1018,7 +1018,7 @@...
2008-01-22 00:43:17 UTC in giflib -- A library for processing GIFs
-
abadger1999 committed patchset 37 of module giflib to the giflib -- A library for processing GIFs CVS repository, changing 1 files.
2008-01-22 00:32:23 UTC in giflib -- A library for processing GIFs
-
Looks like I only applied half of the intended fix. I've added the other half in cvs. Can you check out the code and test that it works?.
2008-01-22 00:16:10 UTC in giflib -- A library for processing GIFs
-
abadger1999 committed patchset 36 of module giflib to the giflib -- A library for processing GIFs CVS repository, changing 2 files.
2008-01-22 00:14:46 UTC in giflib -- A library for processing GIFs
-
Fix committed to cvs.
2008-01-21 23:44:49 UTC in giflib -- A library for processing GIFs
