Heritrix: Internet Archive Web Crawler

Tracker: Bugs

5 Bad synchronization causes NPE in StatisticsTracker - ID: 1124029

Last Update: Comment added ( karl-ia )

Details:

Due to unsafe Map synchronization, I accidentally get a
NullPointerException in
StatisticsTracker.incrementMapCount, probably causing
incorrect statistics.
Patch is attached.

java.lang.NullPointerException
at
org.archive.crawler.admin.StatisticsTracker.incrementMapCount(StatisticsTra
cker.java:389)
at
org.archive.crawler.admin.StatisticsTracker.incrementMapCount(StatisticsTra
cker.java:366)
at
org.archive.crawler.admin.StatisticsTracker.saveHostStats(StatisticsTracker
.java:698)
at
org.archive.crawler.admin.StatisticsTracker.crawledURISuccessful(Statistics
Tracker.java:691)
at
org.archive.crawler.framework.CrawlController.fireCrawledURISuccessfulEvent
(CrawlController.java:441)
at
org.archive.crawler.frontier.BdbFrontier.finished(BdbFrontier.java:747)
at
org.archive.crawler.framework.ToeThread.run(ToeThread.java:149)

Submitted:

Christian Kohlsch�tter ( ck-heritrix ) - 2005-02-16 15:43

Priority:

Status:

Closed

Resolution:

Fixed

Assigned:

Nobody/Anonymous

Category:

None

Group:

None

Visibility:

Public

Comments ( 2 )

Date: 2007-03-14 00:21 Sender: karl-ia This issue is now discussed in the new JIRA tracker at http://webteam.archive.org/jira/browse/HER-365 -- please add further comments at that location.
Date: 2005-02-17 21:50 Sender: stack-sf Logged In: YES user_id=924942 Thanks for the patch Christian Applied. Closing. Below is the commit message. Fix for '[ 1124029 ] Bad synchronization causes NPE in StatisticsTracker'. Patch contributed by Christian Kohlschutter. * src/java/org/archive/crawler/admin/StatisticsTracker.java (incrementMapCount): Added synchronize around map that holds values incremented (TODO: Check we haven't introduced a bottleneck).

Date: 2007-03-14 00:21
Sender: karl-ia

This issue is now discussed in the new JIRA tracker at
http://webteam.archive.org/jira/browse/HER-365 -- please add further
comments at that location.

Date: 2005-02-17 21:50
Sender: stack-sf

Logged In: YES
user_id=924942

Thanks for the patch Christian Applied. Closing. Below is
the commit message.

Fix for '[ 1124029 ] Bad synchronization causes NPE in
StatisticsTracker'.
Patch contributed by Christian Kohlschutter.
* src/java/org/archive/crawler/admin/StatisticsTracker.java
(incrementMapCount): Added synchronize around map that
holds values
incremented (TODO: Check we haven't introduced a
bottleneck).

Attached File ( 1 )

Filename	Description	Download
statisticstracker-sync-npe	Patch for StatisticsTracker	Download

Changes ( 4 )

Field	Old Value	Date	By
status_id	Open	2005-02-17 21:50	stack-sf
resolution_id	None	2005-02-17 21:50	stack-sf
close_date	-	2005-02-17 21:50	stack-sf
File Added	120287: statisticstracker-sync-npe	2005-02-16 15:43	ck-heritrix

Heritrix: Internet Archive Web Crawler

Tracker: Bugs

Comments ( 2 )

Attached File ( 1 )

Changes ( 4 )

About SourceForge

Find Software

Develop Software

Community

Help