Heritrix: Internet Archive Web Crawler

This issue is now discussed in the new JIRA tracker at
http://webteam.archive.org/jira/browse/HER-276 -- please add further
comments at that location.

Logged In: YES
user_id=924942

Commit message below. Includes fix for the case Gordon just
found where a path relative to the disk dir is specified.

Fix for '[ 1058565 ] Non-default 'logs' location doesn't
show in web UI'.
* src/webapps/admin/logs.jsp
The logging directory can be an absolute path, a path
relative to the
data directory or an unspecified path (The default).
Only the latter used
work when logs were accessed from the UI. This commit
makes it so logs
will be found if any of the above three locations.

Logged In: YES
user_id=144912

Patch works well for case where 'logs' setting is absolute
path. However, in testing, I discovered another case which
is a problem both pre- and post- patch, if a 'disk' setting
(usually blank) is used.

Motivation of 'disk' setting is: if present, 'disk'
specifies a place, either absolute or relative to job dir,
for all other paths to be resolved against. See
CrawlController.getSettingsDir() for implementation.

Unfortunately no version of logs.jsp has considered 'disk'
setting. On the bright side, this setting is rarely used.
Looks like a true fix would involve duplicating the logic of
CrawlController.getSettingsDir() to logs.jsp (ugh!) or to
utility methods in CrawlJob(Handler) or SettingsHandler.
True fix can probably be deferred.

Proposed patch is OK for original test case (absolute 'logs'
setting), but ultimate fix would ideally handle 'disk' too
and without any more code (and possibly less) in logs.jsp.
Feel free to commit patch for 1.2 and leave issue open at
lower priority for later, or see if there's a clean way to
tackle 'disk' as well.

Logged In: YES
user_id=924942

Assigning to gordon for review. Assign back when done.

Logged In: YES
user_id=924942

Retry attachiment of patch.

Logged In: YES
user_id=924942

Here's a fix attached.