Heritrix: Internet Archive Web Crawler

Tracker: Bugs

7 Per host overrides not taking effect. - ID: 1010859

Last Update: Comment added ( karl-ia )

Details:

From the mailing list:

---
I'm trying to add a filter to an overrride for a
specific site. I
create the override, add a URIRegExp filter to it, and
then go to the
settings page. I add the reg exp to it, and click on
Done With The
Override. But when I go back into the override to edit
it, the reg
exp that I entered for the new filter is gone, the
field is blank.
The filter is still present, but no reg exp.

Not sure if this is a bug, or if I'm doing something
incorrectly or
missing something.

Thanks,
Rob
---

I've been able to reproduce the problem. It seems that
the data is never written to the configuration file
(even though the field is added, empty).

Clearly this renders the URIRegExp filter unusable in
overrides. Unsure if this extends to other fields or
filters, did not find any instances during my quick check.

Submitted:

Kristinn Sigurdsson ( kristinn_sig ) - 2004-08-17 16:47

Priority:

Status:

Closed

Resolution:

Fixed

Assigned:

Michael Stack

Category:

None

Group:

1.0.1

Visibility:

Public

Comments ( 7 )

Date: 2007-03-14 00:15 Sender: karl-ia This issue is now discussed in the new JIRA tracker at http://webteam.archive.org/jira/browse/HER-232 -- please add further comments at that location.
Date: 2004-08-31 23:12 Sender: stack-sf Logged In: YES user_id=924942 Close the issue. Backported the fix.
Date: 2004-08-31 23:10 Sender: nobody Logged In: NO Fixed. Was awkward one to find. Problem was passing of a global context instead of a local per-host context. Below is commit: Fix for "[ 1010859 ] Per host overrides not taking effect." and refactoring to remove duplicate code and moving code out of jsp back into classes. * src/webapps/admin/include/jobconfigure.jsp Moved writeNewOrderFile from here to new class JobConfigureUtils. Moved in here duplicate setup code from the three configure.jsp files. Formatting. Line lengths. * src/webapps/admin/jobs/configure.jsp * src/webapps/admin/jobs/refinements/configure.jsp Use new JobConfigureUtils.writeNewOrderFile. Remove duplicate setup code now in jobconfigure.jsp include. Formatting. Line lengths. * src/webapps/admin/jobs/per/configure.jsp We were setting an attribute with wrong context (We ignore attribute not found exceptions apparently as part of normally processing so was awkward bug to find). Use new JobConfigureUtils.writeNewOrderFile. Remove duplicate setup code now in jobconfigure.jsp include. Formatting. Line lengths.
Date: 2004-08-27 09:15 Sender: kristinn_sig Logged In: YES user_id=892643 If you have not already, I'd suggest asking John Erik about 'transient' attributes.
Date: 2004-08-27 04:09 Sender: stack-sf Logged In: YES user_id=924942 Settings that don't hold are attributes that are 'transient'. Trying to figure what that really means and why most are not transient while some are.
Date: 2004-08-24 21:01 Sender: stack-sf Logged In: YES user_id=924942 Attached patch that might be related to this issue. At the least, should include in backport.
Date: 2004-08-19 17:40 Sender: ia_igor Logged In: YES user_id=715474 Dan and I found that the following overrides are also not written to the disk therefore not taking effect: - max-speculative-hops - max-referral-hops - max-embed-hops

Attached File ( 1 )

Filename	Description	Download
nullvalue.patch	Check for null value.	Download

Changes ( 12 )

Field	Old Value	Date	By
close_date	-	2004-08-31 23:12	stack-sf
resolution_id	None	2004-08-31 23:12	stack-sf
status_id	Open	2004-08-31 23:12	stack-sf
File Added	99031: nullvalue.patch	2004-08-24 21:01	stack-sf
assigned_to	gojomo	2004-08-24 00:00	gojomo
assigned_to	nobody	2004-08-23 23:59	gojomo
assigned_to	gojomo	2004-08-23 23:53	gojomo
assigned_to	nobody	2004-08-23 23:53	gojomo
priority	6	2004-08-23 23:52	gojomo
priority	5	2004-08-23 20:30	gojomo
artifact_group_id	None	2004-08-19 21:40	stack-sf
summary	Missing regexp when adding filters in overrides	2004-08-19 17:40	ia_igor

Heritrix: Internet Archive Web Crawler

Tracker: Bugs

Comments ( 7 )

Attached File ( 1 )

Changes ( 12 )

About SourceForge

Find Software

Develop Software

Community

Help