Menu

#83 cdbackup feature request: replace space by underscore.

Freevo 1.x series
closed
nobody
Plugins (215)
5
2006-12-30
2006-12-14
No

Hi,

I have a feature request:
I would like an option in cdbackup to replace spaces in dirs and filenames with under scores "_".

Thats all :)

Cheers,
Joris

Discussion

  • Duncan Webb

    Duncan Webb - 2006-12-14

    Logged In: YES
    user_id=104395
    Originator: NO

    In rel-1 at r8728, I have added two new config variables: CD_RIP_REPLACE_SPACE and CD_RIP_CASE.

    CD_RIP_REPLACE_SPACE can be assigned a character to replace a space in the file name e.g. '-', '~', but it can be anything you like.

    CD_RIP_CASE changes the case of the file name, it can be 'upper', 'lower', 'title', anything else does nothing.

    See local_conf.py.example for other CD_RIP settings.

     
  • Duncan Webb

    Duncan Webb - 2006-12-14
    • milestone: --> Freevo 1.x series
    • status: open --> pending
     
  • Duncan Webb

    Duncan Webb - 2006-12-14

    Logged In: YES
    user_id=104395
    Originator: NO

    Opps I've missed directory names, do this later.

     
  • Duncan Webb

    Duncan Webb - 2006-12-14
    • status: pending --> open
     
  • Duncan Webb

    Duncan Webb - 2006-12-15
    • status: open --> pending
     
  • Duncan Webb

    Duncan Webb - 2006-12-15

    Logged In: YES
    user_id=104395
    Originator: NO

    Directories are now done too.

    In rel-1 svn at r8729.

     
  • Joris Vandalon

    Joris Vandalon - 2006-12-15
    • status: pending --> open
     
  • Joris Vandalon

    Joris Vandalon - 2006-12-15

    Logged In: YES
    user_id=1668874
    Originator: YES

    Hi,

    I've tested cdbackup but i'm nothing happens and i'm seeing the following in the log:

    Exception in thread Thread-6:
    Traceback (most recent call last):
    File "threading.py", line 442, in __bootstrap
    self.run()
    File "/usr/lib/python2.4/site-packages/freevo/audio/plugins/cdbackup.py", line 261, in run
    self.cd_backup_threaded(self.device, rip_format='mp3')
    File "/usr/lib/python2.4/site-packages/freevo/audio/plugins/cdbackup.py", line 290, in cd_backup_threaded
    if config.CD_RIP_CASE.lower() == 'lower':
    AttributeError: 'NoneType' object has no attribute 'lower'

     
  • Joris Vandalon

    Joris Vandalon - 2006-12-15

    Logged In: YES
    user_id=1668874
    Originator: YES

    This only happens when the CD_RIP_CASE option is not in the config file :)

     
  • Joris Vandalon

    Joris Vandalon - 2006-12-15

    Logged In: YES
    user_id=1668874
    Originator: YES

    Hey,

    There is still somewhat of an issue with lame:

    cdbackup.py (429): lame: ['/usr/bin/lame', '-b', '160', '--tt', u'Bustin Like This (previously Unreleased)', '--ta', u'Junkie Xl', '--tl', u'Saturday Teenage Kick (special Limited Edition)', '--tn', '03,15', '--tg', u'misc', '--id3v2-only', '/tmp/track_03_being_ripped.wav', u'/mnt/media/music/Junkie_Xl/Saturday_Teenage_Kick_(special_Limited_Edition)/03_-_Bustin_Like_This_(previously_Unreleased).mp3']

    My guess is that the "u" before the title/artist/track name has something to do with it :)

     
  • Duncan Webb

    Duncan Webb - 2006-12-15

    Logged In: YES
    user_id=104395
    Originator: NO

    That was stupid of me about the NoneType, should have tested it against the defaults.

    Fixed in rel-1 at r8730

    The u'' in this case is not a problem.

    Here's one I've just ripped...

    cdbackup.py (431): lame: ['/usr/bin/lame', '--vbr-new', '-b', '192', '-h', '--tt', u'Mannish Boy', '--ta', u'Muddy Waters', '--tl', u'Hard Again', '--tn', '01,9', '--tg', u'blues', '--id3v2-only', '/tmp/track_01_being_ripped.wav', u'/freevo/music/muddy_waters/hard_again/01_-_mannish_boy.mp3']

    eyeD3 /freevo/music/muddy_waters/hard_again/01_-_mannish_boy.mp3

    01_-_mannish_boy.mp3 [ 7.39 MB ]
    --------------------------------------------------------------------------------
    Time: 5:23 MPEG1, Layer III [ ~191 kb/s @ 44100 Hz - Joint stereo ]
    --------------------------------------------------------------------------------
    ID3 v2.3:
    title: Mannish Boy artist: Muddy Waters
    album: Hard Again year: None
    track: 1 genre: Blues (id 0)

     
  • Joris Vandalon

    Joris Vandalon - 2006-12-15

    Logged In: YES
    user_id=1668874
    Originator: YES

    Hey,

    I'm getting: "Unknown genre: 'misc'. Specify genre name or number"
    Seems a lame issue, can besolved by putting the --ignore-tag-errors before the --tg flag.

    Cheers,
    Joris

     
  • Duncan Webb

    Duncan Webb - 2006-12-15

    Logged In: YES
    user_id=104395
    Originator: NO

    Commit in rel-1 at r8732

    Thanks

     
  • Duncan Webb

    Duncan Webb - 2006-12-15
    • status: open --> pending
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • SourceForge Robot

    • status: pending --> closed
     

Log in to post a comment.