Because SquirrelMail has to copy a message to the trash
folder *before* deleting it, we run into a situation
where a user over quota who has move_to_trash turned on
cannot delete any messages. In fact, even if the
message didn't have to be copied before deletion this
would present a problem depending on how over quota a
user is and how big the deleted message is. One
possible approach would be to disable quotas on each
users' Trash folders, but that's not a very pleasant
solution. Instead, I've grabbed the quota functions out
of Bill Shupp's quota_usage plugin and integrated them
into sqimap_messages_delete(). There is a namespace
collision with the quota_usage plugin because Bill
opted to use sqimap_get_quota() as the name for his
function, which is IMO the most reasonable name for the
one I put in imap_messages.php, but since they work the
same it's a minor fix.
I've attached a unified diff against SquirrelMail 1.2.9.
Tomas Kuliavas
None
None
Public
|
Date: 2006-09-30 10:26 Logged In: YES |
|
Date: 2006-09-25 20:29 Logged In: YES |
|
Date: 2005-04-06 22:12 Logged In: YES |
| Filename | Description | Download |
|---|---|---|
| delete_quota_hack.txt | Unified diff (against SM 1.2.9) of fix | Download |
| Field | Old Value | Date | By |
|---|---|---|---|
| status_id | Open | 2006-09-30 10:26 | tokul |
| close_date | 2005-04-06 22:12 | 2006-09-30 10:26 | tokul |
| resolution_id | Out of Date | 2006-09-30 10:26 | tokul |
| assigned_to | nobody | 2006-09-25 20:29 | tokul |
| status_id | Closed | 2005-04-08 16:55 | kink |
| data_type | 423679 | 2005-04-08 16:55 | kink |
| category_id | Folders | 2005-04-08 16:55 | kink |
| resolution_id | None | 2005-04-06 22:12 | kink |
| status_id | Open | 2005-04-06 22:12 | kink |
| close_date | - | 2005-04-06 22:12 | kink |
| priority | 5 | 2002-12-20 12:10 | kink |
| File Added | 36573: delete_quota_hack.txt | 2002-12-01 12:04 | madhack |
Copyright © 2010 Geeknet, Inc. All rights reserved. Terms of Use