acmemail

Logged In: YES
user_id=125882

I ran into the problem on my server too and was about to try
to patch it when I found this. Thanks for the patch,
unfortunately the lines got wrapped when you sent it so I had
to clean it up a bit before I could apply it.

I also would like to encourage the developers to take the
patch.

Logged In: NO

I fixed the bug on my server.
Here is the bug fix:
# diff -c acmemail_orig.cgi acmemail.cgi
*** acmemail_orig.cgi Thu Jan 16 12:56:29 2003
--- acmemail.cgi Thu Jan 16 13:00:43 2003
***************
*** 122,128 ****
my $bcc = $q->param('bcc');
my $subject = $q->param('subject');
my $body = $q->param('body');
! my $attachment = $q->param('attachment');
my $reply = $q->param('reply');
my $replytoall = $q->param('replytoall');
my $forward = $q->param('forward');
--- 122,130 ----
my $bcc = $q->param('bcc');
my $subject = $q->param('subject');
my $body = $q->param('body');
! # changed by dsweet@tgd-inc.com on 20030116
! #my $attachment = $q->param('attachment');
! my $attachname = $q->param('attachment');
my $reply = $q->param('reply');
my $replytoall = $q->param('replytoall');
my $forward = $q->param('forward');
***************
*** 252,257 ****
--- 254,260 ----


# Let's worry about the attachment now...
+ my $attachment=""; # added by dsweet@tgd-inc.com on 20030116
my $attachment_type;
{
my $fh = $q->upload('attachment');
***************
*** 678,683 ****
--- 681,688 ----
$attachment, $attachment_type, $body) }
elsif (defined $send) { mail($q, $cclient, $mailbox, $offset,
$username,
$to, $cc, $bcc, $inreplyto, $subject, $attachment,
+ # following added by dsweet@tgd-inc.com on 20030116
+ $attachname,
$attachment_type, $body) }
elsif (defined $forward) { forward($q, $cclient, $forward)
}
elsif (defined $reply) { reply($q, $cclient, $reply, $replytoall)
}
***************
*** 1207,1213 ****

sub mail($$$$$$$$$$$$$) {
my($q, $cclient, $mailbox, $uid,
! $username, $to, $cc, $bcc, $inreplyto, $subject, $attachment,
$attachment_type, $body) = @_;

if (not $to) {
print qq|<b>Please enter a recipient for this
message</b><br>|;
--- 1212,1220 ----

sub mail($$$$$$$$$$$$$) {
my($q, $cclient, $mailbox, $uid,
! # following changed by dsweet@tgd-inc.com on 20030116
! # $username, $to, $cc, $bcc, $inreplyto, $subject, $attachment,
$attachment_type, $body) = @_;
! $username, $to, $cc, $bcc, $inreplyto, $subject, $attachment,
$attachname, $attachment_type, $body) = @_;

if (not $to) {
print qq|<b>Please enter a recipient for this
message</b><br>|;
***************
*** 1241,1246 ****
--- 1248,1255 ----
if (defined $attachment && (length($attachment) > 0)) {
$top->attach(Data => $attachment,
Type => $attachment_type,
+ Filename => $attachname, # added by dsweet@tgd-inc.com on
+ # 20030116
Encoding => '-SUGGEST');
}
#

I encourage the acmemail team to incorporate the bug fix into a new
release of the stable version of acmemail and close this bug.

--dsweet@tgd-inc.com

Logged In: NO

Just in case the bug may have been fixed in 2.2.4, I thought I would
upgrade. No joy though.

--dsweet

Logged In: NO

My email address is dsweet@tgd-inc.com.