Sorry for not splitting up this patch in several ones, but it's late :)
The first point is a simple one: Calling "python setup.py" with
"python2" is not always
desirable, for example on my Debian unstable system. Instead, the Python
interpreter that called
the ciphon.py script should be used, which is sys.executable.
I also rewrote part of the file handling logic, because the current
approach has some
weaknesses. What I particularly didn't like was that the subdirectory after
unpacking needs to
be called <packagename>-<majorversion>-<minorversion>.
Above all becausae the pyPgSQL package,
which I intend to submit shortly doesn't follow this convention. My
solution is to unpack the
package in a temporary directory, then look which subdirectory got created
there (hopefully only
one ...).
Also I propose not to do all the work in ~/.ciphon but only keep the config
files there. IMHO
all the real work should be done in temporary directories and temporary
files. My patch goes in
this direction. It's only a start, but I'm willing to help out in the
future.
Suchandra Thapa
None
None
Public
|
Date: 2002-10-22 15:19 Logged In: YES |
|
Date: 2002-08-02 07:46 Logged In: YES |
|
Date: 2002-07-10 12:07 Logged In: YES |
|
Date: 2001-12-20 17:15 Logged In: YES |
| Filename | Description | Download |
|---|---|---|
| ciphon_gh_01.dif | Download |
| Field | Old Value | Date | By |
|---|---|---|---|
| close_date | 2002-10-12 05:20 | 2002-10-22 15:20 | ssthapa |
| status_id | Pending | 2002-10-22 15:19 | ssthapa |
| status_id | Closed | 2002-10-12 05:20 | ssthapa |
| resolution_id | Out of Date | 2002-10-12 05:20 | ssthapa |
| close_date | 2002-08-02 07:46 | 2002-10-12 05:20 | ssthapa |
| status_id | Open | 2002-08-02 07:46 | ghaering |
| resolution_id | None | 2002-08-02 07:46 | ghaering |
| close_date | - | 2002-08-02 07:46 | ghaering |
| assigned_to | nobody | 2001-12-20 16:50 | ssthapa |
| File Added | 14898: ciphon_gh_01.dif | 2001-12-19 03:05 | ghaering |
Copyright © 2009 Geeknet, Inc. All rights reserved. Terms of Use