News Clipper

Logged In: YES
user_id=11103

Okay, upon taking another look, I accept the patch with some
modifications. The problem is not with parseDate('now'), which will never
return undef, but rather the other calls to parseDate(). I've done your "if
defined($val)" check for all parsed dates (except for 'now').

First, sorry I didn't respond sooner. I thought I would be auto-notified of
patches

I'm not sure I see the benefit of this patch. AFAIK,
parsedate("now") will never return undef because "now"
is a recognized time for Time::ParseDate. (I'm looking at the 1.23 version
of NC.)

I guess someone could write a handler with an invalid day, but I would
think that this would be caught by the handler writer when they test it.

Did you have a particular error case in mind that this patch would fix?

3 small problems with this patch:

* The problematic function's name is parsedate not parsedata.
* In the first if-clause it should read $temp_now instead of $temp_date.
* In the second if-clause it should read $parsedDate instead of
$parseDate.

The real problem is that parsedate() returns
undef on some cases.
This mean that all data returned by it has to be checked it defined before
using it.