Automatically Tuned Linear Algebra Soft.

Tracker: Bugs

7 Improper call of gerk_axpy in ATL_zgerk_1x4_sse3.c - ID: 2893762

Last Update: Comment added ( rwhaley )

Details:

I'm trying to build atlas-3.9.16.

At line 321 of /tune/blas/ger/CASES/ATL_zgerk_1x4_sse3.c, gerk_axpy is
called.

> Mjoin(PATL,gerk_axpy)(N-N4, alpha, X, 1, Y+incY*(N4 SHIFT), incY,
> A+N4*(lda SHIFT), lda);

However, gerk_axpy is defined in src/blas/ger/ATL_gerk_axpy.c as follows:

> void Mjoin(PATL,gerk_axpy)
> (const int M, const int N, const SCALAR alpha, const TYPE *X, const
int incX,
> const TYPE *Y, const int incY, TYPE *A, const int lda)

The number of argument doesn't match.
I think that the caller should specify M.

Submitted:

sf1021 ( sf1021 ) - 2009-11-07 09:52

Priority:

Status:

Closed

Resolution:

Fixed

Assigned:

R. Clint Whaley

Category:

Install problem

Group:

Developer

Visibility:

Public

Comments ( 2 )

Date: 2009-11-16 14:36 Sender: rwhaley fixed in 3.9.17
Date: 2009-11-13 15:46 Sender: rwhaley Thank you very much for the detailed report: you have found a bug in ATLAS. The lack of an M argument is not the only fix, you also need to change the prior calls to use N4: if (N4) { if ((ia>>4)<<4 == ia && (ix>>4)<<4 == ix) gerk_sse3(M, N4, alpha, X, incX, Y, incY, A, lda); else gerk_sse3u(M, N4, alpha, X, incX, Y, incY, A, lda); } if (N4 != N) Mjoin(PATL,gerk_axpy)(M, N-N4, alpha, X, 1, Y+incY(N4 SHIFT), incY, A+N4(lda SHIFT), lda); I have fixed this in the basefiles, so I can close the report once 3.9.17 is released. Thanks, Clint

Date: 2009-11-16 14:36
Sender: rwhaley

fixed in 3.9.17

Date: 2009-11-13 15:46
Sender: rwhaley

Thank you very much for the detailed report: you have found a bug in ATLAS.
The lack of an M argument is not the only fix, you also need to change the
prior calls to use N4:

if (N4)
{
if ((ia>>4)<<4 == ia && (ix>>4)<<4 == ix)
gerk_sse3(M, N4, alpha, X, incX, Y, incY, A, lda);
else
gerk_sse3u(M, N4, alpha, X, incX, Y, incY, A, lda);
}
if (N4 != N)
Mjoin(PATL,gerk_axpy)(M, N-N4, alpha, X, 1, Y+incY*(N4 SHIFT),
incY,
A+N4*(lda SHIFT), lda);

I have fixed this in the basefiles, so I can close the report once 3.9.17
is released.

Thanks,
Clint

Attached File

Changes ( 11 )

Field	Old Value	Date	By
status_id	Open	2009-11-16 14:36	rwhaley
close_date	-	2009-11-16 14:36	rwhaley
resolution_id	Accepted	2009-11-16 14:36	rwhaley
category_id	None	2009-11-13 15:46	rwhaley
artifact_group_id	None	2009-11-13 15:46	rwhaley
priority	5	2009-11-13 15:46	rwhaley
category_id	Problems during install	2009-11-13 15:43	rwhaley
resolution_id	None	2009-11-13 15:43	rwhaley
artifact_group_id	Developer (v3.9.x)	2009-11-13 15:43	rwhaley
assigned_to	nobody	2009-11-13 15:43	rwhaley
data_type	379482	2009-11-13 15:43	rwhaley

Automatically Tuned Linear Algebra Soft.

Tracker: Bugs

Comments ( 2 )

Attached File

No Files Currently Attached

Changes ( 11 )

About SourceForge

Find Software

Develop Software

Community

Help