Donate Share

SMPlayer

Tracker: Patches

5 fix for bug ID: 2854097 incorrect osd string encoding - ID: 2893306
Last Update: Comment added ( rvm )

Mplayers slave command osd_show_text assumes that text to display is
encoded in utf8.

While writting command to slave process smplayer uses
QString::toLocal8Bit() on this string
which will work on systems with utf8 locale. However it brakes when locale
is non-utf8
and the text in OSD display is garbled. This patch fixes this situation
making sure that
text is passed to slave process in utf8 encoding no matter what locale is
used on users system.


Paweł Pękala ( c0rnholio ) - 2009-11-06 14:34

5

Closed

None

Nobody/Anonymous

None

None

Public


Comment ( 1 )

Date: 2009-11-07 01:17
Sender: rvmProject AdminAccepting Donations

I didn't know that the command osd_show_text expected the string in utf8.
The mplayer documentation doesn't say anything about...

I fixed it in a more generic way in r3312. Thanks :)


Attached File ( 1 )

Filename Description Download
patch-fix-osd-encoding bugfix 2854097 Download

Changes ( 3 )

Field Old Value Date By
status_id Open 2009-11-07 01:17 rvm
close_date - 2009-11-07 01:17 rvm
File Added 349777: patch-fix-osd-encoding 2009-11-06 14:34 c0rnholio