Share

PNG reference library: libpng

Tracker: Bugs

5 more cmake bugfixes and improvements - ID: 2889556
Last Update: Comment added ( glennrp )

I tested libpng-1.4.0beta88 today since I know libpng is headed for a
stable release. I found an issue and made a couple of improvements while I
was looking at the code

1. [BUG] The libpng-config and libpng14-config scripts were not being "make
install"ed with the executable bit set.
2. [feature] I fixed the add_test() call which was commented out and
enabled testing so now you can use "make test" which runs the pngtest
program
3. [feature] I added some code which sets the CMAKE_BUILD_TYPE to
RelWithDebInfo on UNIX platforms if it's not specified by the user. This
makes the code compile with -O2 & -g by default.


Philip Lowman ( plowman ) - 2009-10-30 16:52

5

Open

Accepted

Glenn Randers-Pehrson

makefiles

None

Public


Comments ( 2 )




Date: 2009-10-30 21:07
Sender: glennrpProject AdminAccepting Donations

Actually the next stable release will spring from libpng-1.2.41beta08 not
1.4.0beta88. I will port your changes to 1.2.41beta as well, and will move
CMakeLists.txt up out of the scripts directory.

Glenn


Date: 2009-10-30 20:46
Sender: glennrpProject AdminAccepting Donations

I pushed your patch into the "devel" GIT repository, version beta89.


Log in to comment.

Attached File ( 1 )

Filename Description Download
libpng-1.4.0beta88+more_cmake_fixes.diff fixes Download

Changes ( 2 )

Field Old Value Date By
resolution_id None 2009-10-30 20:46 glennrp
File Added 348870: libpng-1.4.0beta88+more_cmake_fixes.diff 2009-10-30 16:52 plowman