Arianne RPG

Hi yoriy,

thank you for your patch.

I committed it to to CVS and added a few suggestion for improvements below


* line 71: MAX_QUEST_REPEAT_TIME / MIN_QUEST_REPEAT_TIME

please set them to the real values and use the test ones as comments. It is
too easily forgotten the other way


* lines 76-87: private int phase;
please use an enum


* line 177-200: class AnswerOrOfferReward implements ChatAction {
please let ChatAction and ChatCondition classes end in ...Action or
...Condition: AnswerOrOfferRewardAction
please refactor this to use a new PiedPiperPhaseConditions instead

* line 205-230: class RewardPlayer implements ChatAction {
please see above

* line 235-259: class DetailsKillings implements ChatAction {
please rename to DetailsKillingsAction
somewhere in or around Grammar.java there is a method to create lists of
items with quantities

* lines 291-293: if((player.getQuest(QUEST_SLOT)=="done")|| ...
please check first for == null and then use equals for "" and "done"


* line 335-336: if(i==RAT_TYPES.size()) {}
this is a strange empty block, is there something to be done?


* line 484: } catch (IndexOutOfBoundsException ioobe) {
is this an exception you expect? If not please, use logger.error("...",
ioobe);


* line 565: step_test();
the javadoc for that method says: "WARNING: Dont use in game! For testing
only"


*line 621-626 class CircumstancesOfDeath {
please make the fields private and use a constructor or set-methods to set
the values and get-methods to read them



without line numbers (after i splitted the classes)

logger.error("null observer was not added.");
please use this to print the stacktrace: logger.error("null observer was
not added.", new Throwable());


class RatsObserver:
class RatsObserver implements Observer {
@Override
public void update (Observable obj, Object arg) {

please set your java compiler level to 5.0. In 5.0 @Override is only
allowed at operations which have a method in the super class, not for
operations defined in an interface. This is out right stupid and was fixed
in Java 6, but we want to be compatible to Java 5.