Liferea

Changes released in 1.6.1 and 1.7.2.

Thanks for retesting! You are right it didn't solve the problem.

Therefore I did the following:
for 1.6: I added your patch to the source
for 1.7: I rewrote the rule.[ch] code to avoid exposing globals or
rule_init() at all

I think this should solve the issue in both branches.

I tried your patch for 1.6.0 (rev 5194) and it doesn't work. It does
prevent the segmentation fault, but the combobox in the rule editor is now
completly empty.

Thanks for analyzing the problem and the patch!

To fix SF #2861203 I added the following solution:

Index: src/ui/rule_editor.c
===================================================================
--- src/ui/rule_editor.c (Revision 5192)
+++ src/ui/rule_editor.c (Arbeitskopie)
@@ -198,7 +198,8 @@

if (gtk_combo_box_get_active_iter (optionmenu, &iter)) {
gtk_tree_model_get (gtk_combo_box_get_model (optionmenu), &iter, 1,
&changeRequest, -1);
- do_ruletype_changed (changeRequest);
+ if (changeRequest)
+ do_ruletype_changed (changeRequest);
}
}

I want to avoid exposing the rule initialization to the dialog code. I
hope you do not mind.

To be released with 1.6.1 and 1.7.2. Please retest!