Fuse - the Free Unix Spectrum Emulator

4095 fixes this.

I've checked in what I think the correct fix is under revision 4095, please
add a followup to this issue if I've made a mistake with the checked in
code.

Obviously, meant the right way earlier (very Dvorak typo). I have a fixed
copy of the patch but don't know what to do about uploading it.

Actually, it does work if you take the size_t out of those for loops.
Tested with 8 out of 10 buttons set to "fire", it works, so, with that
minor fix, this may well be the light way to fix it, unless someone knows
different.

Patch does not work. Once patched, the following errors occur on
compiling:

In file included from gtkjoystick.c:40:
../uijoystick.c: In function ‘ui_joystick_init’:
../uijoystick.c:164: error: redeclaration of ‘i’ with no linkage
../uijoystick.c:149: error: previous declaration of ‘i’ was here
../uijoystick.c:164: error: ‘for’ loop initial declaration used
outside C99 mode
../uijoystick.c:165: error: ‘for’ loop initial declaration used
outside C99 mode
../uijoystick.c:149: warning: unused variable ‘j’

Perhaps line 149 is unnecessary - that cancels any errors relating to it -
but the for loop. errors still occur and I don't understand the reason.

Could you try the untested patch attached to see if it resolves the issue
for you? I don't have the hardware to test this issue.

This makes sense, what is happening is that in the routines for polling for
joystick state, we check the state for all buttons and send a "press" or
"release" event for each depending on whether the button is pressed or not.
If two buttons are mapped to the same action and one is pressed and one is
not, we end up sending a press and release event for the same key at the
same time so it appears not to be pressed. We should keep track of the
state of all buttons and only send events when there is a transition in the
state of a given button off->on or on->off.

It turns out I was wrong about the actual effect. All 10 buttons do work,
but if two of them are bound to the same function in fuse, only the higher
numbered one works... so, still a bug, but workable around.