Share

AWS Toolkit for Eclipse

Tracker: Issue Tracker

5 Code Optimization - ID: 2856505
Last Update: Settings changed ( fulghum )

As shown in the attachment, the code in InstanceSelectionTable.java code
may be optimized for better performance


Sanjay Chaudhuri ( account4sanjay ) - 2009-09-10 22:44

5

Closed

Accepted

Nobody/Anonymous

Account Management

None

Public


Comments ( 4 )

Date: 2009-11-23 04:32
Sender: fulghumProject Admin

Hey Sanjay,

patch has been submitted:
http://aws-eclipse.svn.sourceforge.net/viewvc/aws-eclipse?view=rev&revision=184

Thanks for the contribution,
j


Date: 2009-11-04 06:36
Sender: fulghumProject Admin

Hey Sanjay,

I applied the latest patch and tested it out tonight. Overall, things
look really great! It's exciting to see the filtering in the instance view
and AMI browser view.

I ran into a few small issues, but I've been able to work around them:
1 - null AMI count label - FilteredAmiSelectionTable was missing a call
to "statusBar.setRecordLabel", so it was displaying "null" instead. I've
gone ahead and fixed this.
2 - Filter icons wrap down off the view toolbar. These icons must just
be too tall. I replaced them with different icons and the problem went
away. I'll search around in our icon library to see what icons make the
most sense for these filters.
3 - AMI count didn't get updated on the first load - I got this working
by setting noOfAMIs when we load the images.
4 - AMI count doesn't update with filter - I got this working, too, but
might add a new method to SelectionTableListener to make it a little
cleaner (maybe something like
SelectionTableListener.displayedRecordsChanged(int displayedRecords))

I'll get things moving so we can formally get this accepted, and I'll find
some icons for the filter actions on the view toolbar.

Thanks again for all the effort put into this,
j


Date: 2009-10-21 04:35
Sender: account4sanjay

Made few additional bug fixes


Date: 2009-09-10 22:50
Sender: account4sanjay

Patch submitted. The following open issues also has been addressed with
this patch:

Issue: 2717272
Filters for EC2 AMI Browser view
https://sourceforge.net/tracker/?func=detail&aid=2717272&group_id=256815&atid=1127005

Issue: 2717281
Filter for terminated instances in the EC2 Instances view
https://sourceforge.net/tracker/?func=detail&aid=2717281&group_id=256815&atid=1127005

Issue: 2717294
More filtering for EC2 Instances view
https://sourceforge.net/tracker/?func=detail&aid=2717294&group_id=256815&atid=1127005


Attached Files ( 3 )

Filename Description Download
patch.txt Patch Download
CodeOptimization.jpg Screenshot Download
patch.txt Updated Patch Download

Changes ( 7 )

Field Old Value Date By
status_id Open 2009-11-23 04:32 fulghum
resolution_id None 2009-11-23 04:32 fulghum
allow_comments 1 2009-11-23 04:32 fulghum
close_date - 2009-11-23 04:32 fulghum
File Added 347513: patch.txt 2009-10-21 04:34 account4sanjay
File Added 342500: patch.txt 2009-09-10 22:50 account4sanjay
File Added 342499: CodeOptimization.jpg 2009-09-10 22:44 account4sanjay