Donate Share

Ext2 Filesystems Utilities

Tracker: Bugs

5 reserved identifier violation - ID: 2854411
Last Update: Settings changed ( tytso )

I suggest to try the search pattern "_+[A-Z]+" on the source files. You
will find a some places where names begin with an underscore and an
uppercase letter.

Examples:
- _EXT2FS_EXT2FS_H

http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=blob;f=lib/ext2fs/ext2fs.h
;h=5c3d17f642d5f21ec73165cedd7a7920e33156d2;hb=HEAD

- _UUID_UUIDD_H

http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=blob;f=lib/uuid/uuidd.h;h=
c71f4b788352373edc41a58f8f8f7bde7853da14;hb=HEAD#l35

This does not fit to the expected naming conventions of the C language
standard.
http://en.wikipedia.org/wiki/Reserved_identifier

See also section "7.1.3 Reserved identifiers".
http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1124.pdf


Markus Elfring ( elfring ) - 2009-09-08 14:55

5

Closed

Wont Fix

Theodore Ts'o

libext2

None

Public


Comment ( 1 )

Date: 2009-09-09 00:16
Sender: tytsoProject AdminAccepting Donations

This is a convention used to protect header files from double inclusion.
Some of them are absolutely required, since there are different versions of
these header files provided by the Linux kernel, and the Linux kernel uses
this naming convention. E2fsprogs isn't alone in using this convention.
So does X11, for example.



Attached File

No Files Currently Attached

Changes ( 4 )

Field Old Value Date By
status_id Open 2009-09-09 00:16 tytso
allow_comments 1 2009-09-09 00:16 tytso
close_date - 2009-09-09 00:16 tytso
resolution_id None 2009-09-09 00:16 tytso