Frhed

Will do. I've been busy as well. I'll get to this this weekend.

Can you add the updated patch addressing my comments? Like moving document
to correct folder.

I'm again sorry it has taken so much time to respond. I simply haven't had
any time for Frhed development in past weeks and also had problems with
e-mails coming through so I may have missed some notifications from Sf.net
trackers...

Committed the bug fix to load more than one encoder dll to SVN trunk:
Completed: At revision: 820

> The pyscripts project has all the python dependencies on
> it not the top level solution.

Missed that, thanks for clarifying.

> pyscripts is just based on the addone project file.

Ok. I made that with VS2005. Don't worry about the projec file format we
can always convert it later.

> ok. I'll add that to the todo in the readme. Is it ok
> if I add that later after we get the initial checkin?

Definitely. Lets get this in first and further modifications and
improvements are then a lot easier. I personally prefer smaller commits
which makes it easier to track things later.

>>But can you move the doc to /Docs/Developers/ -folder.

ok

>>One thing I'm not very thrilled about is this makes compiling Frhed to
require Python.

The pyscripts project has all the python dependencies on it not the top
level solution. Currently the top level solution doesn't even know about
the pyscripts project, you have to import it before build-all will even
know about it. So frhed is no more dependent on pyscripts than addone (I
based pyscripts on addone).

>> I still prefer project files to be in VS2003 format.

pyscripts is just based on the addone project file. It contains 1 source
file with a change to add one new header directory and one new lib file
(but VC auto updated it for me to the 2008 format).

So I can see about just hand editing the project file from addone to make
it into the new pyscripts project, or using the tool you describe to submit
it next time. (The details on how to add the header file, and lib
dependencies are also in the docs, I did that in case a user had a
different version of the compiler and wanted to know how to recreate the
pyscripts project file).

>> The bugfix for loading more than one plugins is this? :

yes. Otherwise the second plugin string looks like this ;plugintwo.dll;
and that didn't load.

>>One thing to consider later is to load (Python) encoders from user's
folder.

ok. I'll add that to the todo in the readme. Is it ok if I add that
later after we get the initial checkin?

Thanks a lot for great documentation you have written. Helps a lot. I'll
borrow some of that for the user manual too. But can you move the doc to
/Docs/Developers/ -folder. IMO its better to have one folder for docs than
spread them around the source tree (even though it means you need to cd to
docs folder).

One thing I'm not very thrilled about is this makes compiling Frhed to
require Python. It would be great it people still can compile Frhed without
Python (won't be able to use Python encoders but not everybody need to use
them). Not everybody wants to install Python to compile Frhed.

I still prefer project files to be in VS2003 format. Of course this is not
possible to achieve for everybody (or even most developers?). I have VS2003
in one machine but have rarely access to it. But I can access VS2005 so I
can convert project to it later.

I also just found this conversion tool:
https://sourceforge.net/projects/vspc/
but haven't yet tried it...

I think the interface is OK as first version. Later on we need to add more
info about the plugin for user. Like author, version etc.

The bugfix for loading more than one plugins is this? :
}
- prev_ind = ind;
- ind = buffer.find_first_of(';', prev_ind + 1);
+ prev_ind = ind + 1;
+ ind = buffer.find_first_of(';', prev_ind);
}

I'll commit it as separate commit, Thanks for fixing it.

One thing to consider later is to load (Python) encoders from user's
folder. If user is normal user without admin privileges one cannot install
new plugins to program files folder.

I took a short look at the code and this looks good!

Moving to the patch tracker.