OpenGoo: The Open Suite

Tracker: Bugs

5 Subtasks of repeating tasks not handled correctly - ID: 2830812

Last Update: Comment added ( rgardler )

Details:

* Create a repeating task (A)
* Create a subtask of A (B)
* mark B as complete
* mark A as complete

Expected:
New copy of A (repeating task) with a new copy of subtask B

Actual result:
New copy of A, with a completed copy of subtask of B
Original A is completed, but original B is incomplete

Submitted:

Ross Gardler ( rgardler ) - 2009-08-01 13:04

Priority:

Status:

Open

Resolution:

None

Assigned:

Nobody/Anonymous

Category:

Module - Tasks

Group:

1.5.X

Visibility:

Public

Comment ( 1 )

Date: 2009-08-01 15:16 Sender: rgardler Having explore this a little we find that if A = ta33 and B=ta34 we find that the new version of A (the repeating task) is the closed version, but ta34 is the subtask one that was originally closed. This is because when A is closed it is cloned, but it is the clone that is closed rather than the original. See http://opengoo.cvs.sourceforge.net/viewvc/opengoo/opengoo/application/controllers/TaskController.class.php?revision=1.147&view=markup 1338 // generate completed task 1339 $new_task = $task->cloneTask(); 1340 $new_task->completeTask(); It is done this way around because the cloneTask() method does not clone the repeater settings. I imagine this is because copying the repeater settings causes a problem if a clone is later reopened and then closed again. We would have two open repeating tasks at this point. Closing either will result in a new repeated task, thus we have effectively duplicated the task.

Date: 2009-08-01 15:16
Sender: rgardler

Having explore this a little we find that if A = ta33 and B=ta34 we find
that the new version of A (the repeating task) is the closed version, but
ta34 is the subtask one that was originally closed.

This is because when A is closed it is cloned, but it is the clone that is
closed rather than the original. See
http://opengoo.cvs.sourceforge.net/viewvc/opengoo/opengoo/application/controllers/TaskController.class.php?revision=1.147&view=markup

1338 // generate completed task
1339 $new_task = $task->cloneTask();
1340 $new_task->completeTask();

It is done this way around because the cloneTask() method does not clone
the repeater settings. I imagine this is because copying the repeater
settings causes a problem if a clone is later reopened and then closed
again. We would have two open repeating tasks at this point. Closing either
will result in a new repeated task, thus we have effectively duplicated the
task.

OpenGoo: The Open Suite

Tracker: Bugs

Comment ( 1 )

Log in to comment.

Attached File

No Files Currently Attached

Change

No changes have been made to this artifact.

About SourceForge

Find Software

Develop Software

Community

Help