Share

Bot Sentry

Tracker: Bugs

5 Default allow all users without numbers in username - ID: 2798706
Last Update: Comment added ( deckrider )

Starting line 427 of src/bot-sentry.c
/**
* Block if username contains numbers - allow w/o msg if not
*/
if(strpbrk(*sender, "0123456789") == NULL) {
return retval;
}


Steven Hartzog Jr ( zogjr ) - 2009-05-30 03:41

5

Closed

Wont Fix

David Everly

Feature Request

v1.3.0

Public


Comments ( 4 )

Date: 2009-05-31 12:11
Sender: deckriderProject AdminAccepting Donations

A change like this just seems too likely to return both false positives
and false negatives. I have many good friends with numbers in their user
name. And I've seen plenty of spam which have only letters.


Date: 2009-05-30 21:37
Sender: zogjr

All spam messages that I've received have been via usernames which contain
some amount of numbers in them. While some of the spam might possibly slip
by, I feel that at least for mine own version, that the reduced difficulty
of contacting me makes the modification worthwhile.

Perhaps as a configuration setting, an optional regex to pattern match
names to allow unconditionally? It was code that did what I needed, and as
I didn't want to add a dependency, I chose strpbrk().


Date: 2009-05-30 12:26
Sender: deckriderProject AdminAccepting Donations

Why should bot sentry allow users without numbers to pass?


Date: 2009-05-30 03:42
Sender: zogjr

Submitted through Iiridayn


Attached File

No Files Currently Attached

Changes ( 9 )

Field Old Value Date By
close_date - 2009-05-31 12:11 deckrider
status_id Open 2009-05-31 12:11 deckrider
resolution_id None 2009-05-31 12:11 deckrider
assigned_to nobody 2009-05-31 12:11 deckrider
allow_comments 1 2009-05-31 12:11 deckrider
status_id Pending 2009-05-30 21:37 zogjr
close_date 2009-05-30 12:26 2009-05-30 21:37 zogjr
close_date - 2009-05-30 12:26 deckrider
status_id Open 2009-05-30 12:26 deckrider