Tracker: Bugs

5 1.4.18 EHLO no [ ] around IPv4 address where no domain name - ID: 2793154
Last Update: Comment added ( chrisnewson )

Updated SquirrelMail 1.4.18 and Mercury/32 4.62 (on Apache 2.2.11 / PHP
5.2.9-1) this evening and received following error:

01:00:47.181: Connection from 192.168.1.10, Mon May 18 01:00:47 2009<lf>
01:00:47.181: << 220 newson.org.uk ESMTP server ready.<cr><lf>
01:00:47.201: >> EHLO 192.168.1.10<cr><lf>
01:00:47.201: << 554 Invalid HELO format<cr><lf>
01:00:47.231: >> HELO 192.168.1.10<cr><lf>
01:00:47.231: << 554 Shunned connection - only the QUIT command will be
accepted.<cr><lf>
01:00:47.261: --- Connection closed normally at Mon May 18 01:00:47 2009.
---

Previous version of Mercury/32 accepted IP address without brackets but
current one does not.

Checked RFC 5321 SMTP (Oct 20080) to see which end had the bug but 3.1.4
Address Literals suggests that Mercury/32 is following the RFC.

Can you add the brackets around the IP address please.

Chris



Chris Newson ( chrisnewson ) - 2009-05-18 02:49

5

Closed

Fixed

Nobody/Anonymous

None

None

Public


Comments ( 3 )

Date: 2009-05-23 11:42
Sender: chrisnewson

Yes as you and Thijs thought I am running squirrel mail on an IP address
192.168.1.10 rather than a domain.

You are correct re section I transposed the subsections - but in my
defence it was 3am and I had spent the best part of four hours by then
trying to sort out what was wrong until in the SMTP server logs I spotted
the lack of [ ] was causing a problem in one version of mercury and not the
other.

Thanks for fixing it.

Chris




Date: 2009-05-20 20:48
Sender: pdontthinkProject AdminAccepting Donations

I think it's section 4.1.3, BTW.

I echo Thijs' concern that you are getting an IP address - this should
only happen if you aren't running SM on a domain at all - a very rare use
of SM.

That said, it is a violation of RFC not to do as you suggest. I have
added a fix into SVN. Thanks.


Date: 2009-05-20 15:32
Sender: kinkProject AdminAccepting Donations

This should only happen when you run your webmail on an IP address, say
http://123.45.6.7/squirrelmail
is that indeed what you're doing?


Attached File

No Files Currently Attached

Changes ( 3 )

Field Old Value Date By
status_id Open 2009-05-20 20:48 pdontthink
resolution_id None 2009-05-20 20:48 pdontthink
close_date - 2009-05-20 20:48 pdontthink