Share

checkstyle

Tracker: Patches

5 Share common XSL functions from a util xsl - ID: 2734302
Last Update: Attachment added ( rjatkins )

Attached is a patch to pull out the common functions used by many of the
XSL report generation stylesheets, and make them be shared across all the
scripts.

Additionally, the patch fixes the checkstyle-author.xsl to group the error
results by author, to show error results for files with unknown authors,
and to list all authors, and not just those who need to apply fixes.
Attached is the result of running this updated report on the current (5.0
beta 3) checkstyle source. Note that there are some I18N errors and simple
spelling mistakes with peoples names in this output.

Also fixed one issue with the checkstyle-csv.xsl to wrap the value of the
error message attribute in quotes, but this needs extra work later to
escape any existing quotes in the message (CSV is harder than it looks).


Richard Atkins ( rjatkins ) - 2009-04-05 13:28

5

Open

None

Nobody/Anonymous

None

None

Public


Comments




Log in to comment.

No follow-up comments have been posted.

Attached Files ( 3 )

Filename Description Download
xslt-refactoring.diff Changes to use a common utility xsl script Download
checkstyle-metrics-report-author.html An authors report on checkstyle/src/checkstyle Download
checkstyle-report-utils.xsl The factored out xsl functions Download

Changes ( 3 )

Field Old Value Date By
File Added 321355: checkstyle-metrics-report-author.html 2009-04-05 13:30 rjatkins
File Added 321354: checkstyle-report-utils.xsl 2009-04-05 13:29 rjatkins
File Added 321353: xslt-refactoring.diff 2009-04-05 13:28 rjatkins