Tracker: Feature Requests

5 User config files overwritten during upgrade - ID: 2727419
Last Update: Comment added ( sf-robot )

Privoxy 3.0.12
XP SP3

The user configuration files 'user.action' and 'user.filter', and the main
configuration file 'config.txt', are all overwritten during an
install/upgrade. This should not happen since there is a very high
probability that they will have been modified by the user.

'user.action' and 'user.filter' should never be overwritten since they are
not supposed to contain anything other than user settings.

If the internal format of 'config.txt' has not changed, the existing file
should not be touched. If the format has changed, the installer should
ALWAYS advise the user and offer to do one of the following:

o Merge the new and old files, preserving any user changes and making a
backup of the user's file
o Rename the existing 'config_old.txt'
o Install the new version as 'config_new.txt'


Tim H ( thubb ) - 2009-04-02 21:58

5

Closed

None

Nobody/Anonymous

None

None

Public


Comments ( 8 )

Date: 2009-11-24 02:20
Sender: sf-robotSourceForge.net Site Admin

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).


Date: 2009-11-09 22:25
Sender: daemonui

No, I'm just saying user.config and user.filter are overwritten
Thanks, I followed the instructions somewhere getting only the "current"
part.


Date: 2009-11-09 18:06
Sender: fabiankeilProject Admin

Thanks for the report.

I think the script you are looking for is:
http://ijbswa.cvs.sourceforge.net/viewvc/*checkout*/ijbswa/winsetup/privoxy_winthreads.nsi

Quote:
; save files the user might have changed
; config.txt match-all.action trust.txt user.action
user.filter
; NOTE: rename fails if the destination file already exists
;
[...]

Are you saying this worked for all files but user.action?


Date: 2009-11-09 16:53
Sender: daemonui

3.0.16 still overwrites user.action

http://config.privoxy.org/user-manual/actions-file.html says
user.action - ... will not be upgraded.
This means in my opinion, no overwriting, conclusion: it's a bug.

I could take the installation for windows (I've good knowledge in NSIS)
but the install script is not part of the cvs-repository.



Date: 2009-04-05 03:16
Sender: david__schmidtProject Admin

Sigh; that OS/2 comment was me. Forgot to sign in after navigating here
from email.


Date: 2009-04-05 03:15
Sender: nobody

I went through this issue with OS/2. The way I ended up handling it is to
have the various default config files copied in as 'whatever.new,' then the
installer copies 'whatever.new' over to 'whatever' if 'whatever' didn't
exist before. If there was a prior installation, and there is a
depreciated (and now fatal) keyword, Privoxy doesn't start any more. Or
you get complaints in the log. But at least nobody's changes are
overwritten, and you have the .new files you can look at to find out how
things changed.


Date: 2009-04-05 02:38
Sender: ler762

I'd leave the status as open.

I agree that the current behavior isn't a bug, but it would be nice if the
installer at least preserved the old files by renaming them.

> If the internal format of 'config.txt' has not changed

I wouldn't even try to do that. Not everyone upgrades when a new version
is released, so you'd first have to figure out what version of Privoxy is
installed before deciding if the old config.txt was compatable with the
version of Privoxy being installed. But if you can figure out how to do
that ... patches are welcome :)

Lee




Date: 2009-04-04 14:12
Sender: fabiankeilProject Admin

The installation process is documented to work that way on platforms
without a proper package infrastructure:
http://config.privoxy.org/user-manual/whatsnew.html#UPGRADERSNOTE

Patches are welcome of course, but I don't consider this a Privoxy bug.

Leaving the request open for now, in case Lee disagrees.


Attached File

No Files Currently Attached

Changes ( 11 )

Field Old Value Date By
allow_comments 1 2009-11-24 02:20 sf-robot
status_id Pending 2009-11-24 02:20 sf-robot
close_date 2009-11-09 18:06 2009-11-24 02:20 sf-robot
close_date - 2009-11-09 18:06 fabiankeil
status_id Open 2009-11-09 18:06 fabiankeil
close_date 2009-04-04 14:12 2009-04-05 02:38 ler762
status_id Pending 2009-04-05 02:38 ler762
data_type 361118 2009-04-04 14:12 fabiankeil
close_date - 2009-04-04 14:12 fabiankeil
category_id other 2009-04-04 14:12 fabiankeil
status_id Open 2009-04-04 14:12 fabiankeil