Donate Share

ScummVM

Tracker: Patches

5 Implement getDevices() in backends/midi/dmedia.cpp - ID: 2658665
Last Update: Settings changed ( fingolfin )

This patch is a first attempt to implement getDevices() for the IRIX midi
driver dmedia.cpp.


canavan ( canavan ) - 2009-03-03 20:40

5

Closed

Accepted

Max Horn

None

None

Public


Comments ( 3 )

Date: 2009-03-16 04:15
Sender: fingolfinSourceForge.net Subscriber and DonorProject AdminAccepting Donations

Looks good now, committed as is.

I think we shouldn't bother adding this to the usage text. We just have to
finally overhaul the music/midi driver system to allow passing driver
settings in a formalized way (so no more env variable tricks or custom
config strings / command line stuff, and also the ability to change this
via the GUI).


Date: 2009-03-08 17:25
Sender: canavan

Update patch to fix formatting, add README section on configuration.

I don't see any reference to the equivalent alsa_port in
base/commandLine.cpp, or for that matter anywhere outside alsa.cpp and the
REAME, so I'm not certain what you expect to be added to the usage help. To
be honest, I don'e even know how the ConfMan objects correspond to
commandline options.
File Added: backends_midi_dmedia.patch


Date: 2009-03-08 15:44
Sender: sevSourceForge.net SubscriberProject Admin

Looks pretty good besides one minor code formatting issue at line "if
(0==strcmp(var, portName)) {".

But you also need to add description of that dmedia_port to the readme and
also make it IRIX-specific at compile time in our scummvm usage help.


Attached File ( 1 )

Filename Description Download
backends_midi_dmedia.patch updated patch Download

Changes ( 7 )

Field Old Value Date By
status_id Open 2009-03-16 04:15 fingolfin
resolution_id None 2009-03-16 04:15 fingolfin
assigned_to nobody 2009-03-16 04:15 fingolfin
close_date - 2009-03-16 04:15 fingolfin
File Deleted 316044: 2009-03-08 17:25 canavan
File Added 316811: backends_midi_dmedia.patch 2009-03-08 17:25 canavan
File Added 316044: dmedia.cpp.patch 2009-03-03 20:40 canavan