TimeDoctor

Tracker: Bugs

5 TraceViewer.dispose() is not enough - ID: 2515073

Last Update: Comment added ( maheshdc )

Details:

remains leftPane, rightPane and mainSash.

my suggestion
---
public void dispose() {
mainViewer.dispose();
mainViewer = null;

//start
leftPane.dispose();
rightPane.dispose();
mainSash.dispose(); //add local field "mainSash" and save it
//end
}
---

Submitted:

Takaaki Nakamura ( happyhills ) - 2009-01-17 03:29

Priority:

Status:

Closed

Resolution:

Rejected

Assigned:

Nobody/Anonymous

Category:

None

Group:

None

Visibility:

Public

Comment ( 1 )

Date: 2009-01-19 07:15 Sender: maheshdc Hi, Disposing of leftPane, rightPane and mainSash is not required to be done manually. When creating the leftPane, rightPane or mainSash, they are created using the parent Composite supplied as part of createPartControl in TraceEditor. So, via the normal SWT cleanup, their dispose methods also get called, when TraceEditor is closed (i.e., disposed). To verify this effect, you can add a dispose listener to either of these components and check it. -Mahesh

Date: 2009-01-19 07:15
Sender: maheshdc

Hi,

Disposing of leftPane, rightPane and mainSash is not required to be done
manually.

When creating the leftPane, rightPane or mainSash, they are created using
the parent Composite supplied as part of createPartControl in TraceEditor.

So, via the normal SWT cleanup, their dispose methods also get called,
when TraceEditor is closed (i.e., disposed).

To verify this effect, you can add a dispose listener to either of these
components and check it.

-Mahesh

Attached File

Changes ( 4 )

Field	Old Value	Date	By
status_id	Open	2009-01-19 07:15	maheshdc
resolution_id	None	2009-01-19 07:15	maheshdc
allow_comments	1	2009-01-19 07:15	maheshdc
close_date	-	2009-01-19 07:15	maheshdc

TimeDoctor

Tracker: Bugs

Comment ( 1 )

Attached File

No Files Currently Attached

Changes ( 4 )

About SourceForge

Find Software

Develop Software

Community

Help