Share

Chromium B.S.U.

Tracker: Patches

5 SDL_image - ID: 2153247
Last Update: Comment added ( pabs3 )

I know there are already enough (too many) alternative libraries but I
think SDL_image is better than glpng...


Tristan Heaven ( nyhm ) - 2008-10-08 13:54

5

Open

None

Nobody/Anonymous

None

None

Public


Comments ( 8 )




Date: 2009-08-23 06:38
Sender: pabs3Project Admin

A hint for anyone who wants to work on this:

BuGLe is an OpenGL tracer, it could be used to compare the glpng and
SDL_image OpenGL usage and fix any issues that come up with SDL_image.

http://sf.net/projects/bugle


Date: 2009-02-08 06:40
Sender: pabs3Project Admin

Any progress on fixing the artifacts?


Date: 2008-10-15 06:27
Sender: pabs3Project Admin

Unfortunately I've gone as far as I can with this change and cannot figure
out why there are all the artifacts that there are. I've attached the
latest version, if you could fix it up to get rid of the artifacts, that
would be good.


Date: 2008-10-13 07:23
Sender: nobody

Ugh, PNG_BLEND* are getting in the way. Without implementing them with SDL,
there are several rendering issues that show up. Will try to get it done
this week.


Date: 2008-10-10 08:48
Sender: pabs3Project Admin

Thanks for the patch.

I'm working on cleaning it up a bit, will commit it soon.


Date: 2008-10-08 23:35
Sender: nyhm

Resized that. I'm just not sure how to manipulate the SDL_Surface to get
the same results as you'd get using glpng's PNG_BLEND.

You can put whatever you want for copyright.


Date: 2008-10-08 15:23
Sender: nyhm

I was aiming to get it to look the same with SDL_image and glpng. I think
the only noticeable difference from the original code is the effect around
powerups is larger now, but It'd be easier to just resize powerUpTex.png to
fix that.


Date: 2008-10-08 14:47
Sender: pabs3Project Admin

Excellent! I was thinking of adding an icon to the SDL window, so this will
be good to merge.

Looks good at first glance, some issues;

The copyright on Image.* is obviously wrong, please fix that. Specify it
as "Copyright Foo Bar" rather than "Copyright (c) 2000 Mark B. Allan. All
rights reserved.", the other junk ("(c)" and "All rights reserved.") is no
longer relevant.

There are several places where the Image::load call doesn't result in the
exact same parameters to pngBind as beforehand. I'm wary of introducing
bugs in the glpng bits.

Please remove the unneeded whitespace changes too.

Please also change the README.install file so people know it is an
alternative to glpng.


Log in to comment.




Attached File ( 1 )

Filename Description Download
0001-WIP-merge-sdl-image-patch.patch latest patch Download

Changes ( 5 )

Field Old Value Date By
File Added 297415: 0001-WIP-merge-sdl-image-patch.patch 2008-10-15 06:25 pabs3
File Deleted 296637: 2008-10-15 06:25 pabs3
File Added 296637: chromium-sdlimage.patch 2008-10-08 23:34 nyhm
File Deleted 296579: 2008-10-08 23:34 nyhm
File Added 296579: chromium-sdlimage.patch 2008-10-08 13:54 nyhm