Synfig Animation Studio

Applied the patch from dooglus in svn 2056.

How about this 3rd patch? Just return early if the gradient is empty.
File Added: bug_2096641_patch3.txt

It should be an error for find() to be called with a cpoint that doesn't
exist. I don't think it's a good idea to remove the exception raising
behaviour in that case.

A better fix for this bug would be to stop find() being called when there
are no cpoints in the gradient.

Note also that there are two functions which both raise exceptions when
the cpoint can't be found. If we're going to change the behaviour of one,
shouldn't we also change the other too?

synfig::Gradient::iterator synfig::Gradient::find(const UniqueID &id)
synfig::Gradient::const_iterator synfig::Gradient::find(const UniqueID
&id)const

I've set another solution for this:

Modify the synfig-core/src/synfig/gradient.cpp file instead and catch the
exception returning a valid iterator begin()

See attached patch file.
File Added: bug_2096641_patch2.txt

Looks like a bug in the synfig::Gradient::proximity function, I think it
shouldn't use iter-- at the end of the function.

But in which situation someone would like to delete all the Cpoints?...
I know what you mean. You prefer that I caught the exception with a "try"
command in the gradient.cpp file, right?

Hmm, I don't think this is the right place to fix this. Either the erase
function should fail to remove the last cpoint or synfigstudio should not
crash when no cpoints are in the gradient. Personally I think removing all
cpoints is a valid thing to do so the crash should be avoided instead.

This patch can solve the bug. See attached file.