Share

Synfig Animation Studio

Tracker: Bugs

5 Incorrect error message - ID: 2060732
Last Update: Comment added ( gballintijn )

When selecting the canvas and filename parameter in the parameters panel,
an error message is printed on stderr. It reads "error: EXCEPTION: bad
type: Bad type for curves". An examination of the code
(src/gtkmm/widget_curves.cpp, lines 222 and 397), reveals however that
nothing is wrong, and that this condition is subsequently ignored.

The problem originate from the fact that neither filenames nor canvasses
can be drawn as a curve, so they should be (and are) ignored by the curves
widget. The method of ignoring them, i.e. the exception thrown and caught,
results however also in the printing of an error message, and this is
wrong.

Attached is a patch that consistutes probably the easiest way to avoid this
problem. Another solution would be to introduce a new exception, that
doesn't also constitute an error, e.g. type_not_supported, or move the
condition in the if-statement to the CurveStruct class, to enhance
encapsulation.


Gerco Ballintijn ( gballintijn ) - 2008-08-19 21:57

5

Closed

Fixed

Gerco Ballintijn

Usability

SVN version

Public


Comments ( 3 )




Date: 2008-08-22 20:07
Sender: gballintijnProject Admin


Fixed in r2033.


Date: 2008-08-21 23:53
Sender: pabs3


Patch looks good, apart from the unrelated change in the 3rd hunk
(reformatting a catch statement).

Please apply it to SVN, IIRC you should have access.

In addition, please list yourself in the AUTHORS file.


Date: 2008-08-20 19:31
Sender: gballintijnProject Admin


Slightly improved version (more explicit) that uses a method call.
File Added: patch.txt


Log in to comment.

Attached Files ( 2 )

Filename Description Download
diff Download
patch.txt improved patch Download

Changes ( 5 )

Field Old Value Date By
status_id Open 2008-08-22 20:07 gballintijn
resolution_id None 2008-08-22 20:07 gballintijn
close_date - 2008-08-22 20:07 gballintijn
File Added 289612: patch.txt 2008-08-20 19:31 gballintijn
File Added 289434: diff 2008-08-19 21:57 gballintijn