Joda - Time

Tracker: Bugs

5 Util class for JSP Taglibs is violating Servlet specificatio - ID: 2015343

Last Update: Comment added ( brokenwren )

Details:

In the JSP taglibs, the format tags are making calls to the Util class to
manage the Locale's and conform to the JSTL specification. However, they
are also setting the response Locale using the setLocale method on the
ServletResponse interface.

This violates the servlet specification because by the time these tags are
being execute the output stream and writer have already been used and bytes
might have been already flushed. This method is only to be called before
the Writer or ServletOutputStream have been retrieved.

This also makes it impossible to perform application specific Locale
handling.

Therefore, this code should be removed.

Submitted:

Brian Pontarelli ( brokenwren ) - 2008-07-10 20:10

Priority:

Status:

Open

Resolution:

None

Assigned:

Nobody/Anonymous

Category:

None

Group:

None

Visibility:

Public

Comments ( 2 )

Date: 2008-08-20 15:00 Sender: brokenwren Here's an example violation. These code snippets are executed in order: (Some code in Servlet before response is committed) response.setLocale(Locale.DE); (Joda in JSP) response.setLocale(Locale.EN); (Some other JSP taglib or code called by the JSP) Locale locale = response.getLocale(); // Locale is now English As you can see, the locale going back to the client is going to be German. Then Joda changes it locally, which the client won't ever see. Finally, some other code attempts to retrieve the locale from the response, which will now be English. However, the client really thinks the Locale is German, but everything else now believes it is English. My concern is that Joda is using an API that should only be set by the application and not a taglib. If you want to manage locales I would suggest using an attribute in the request or page context and not messing around with the response.
Date: 2008-08-20 12:34 Sender: kennymacleod Doesn't the servlet container just ignore calls to setLocale() once the response has been committed? I'm not sure if this is violating the servlet spec, or is just misleading.

Date: 2008-08-20 15:00
Sender: brokenwren

Here's an example violation. These code snippets are executed in order:

(Some code in Servlet before response is committed)
response.setLocale(Locale.DE);

(Joda in JSP)
response.setLocale(Locale.EN);

(Some other JSP taglib or code called by the JSP)
Locale locale = response.getLocale();
// Locale is now English

As you can see, the locale going back to the client is going to be German.
Then Joda changes it locally, which the client won't ever see. Finally,
some other code attempts to retrieve the locale from the response, which
will now be English. However, the client really thinks the Locale is
German, but everything else now believes it is English.

My concern is that Joda is using an API that should only be set by the
application and not a taglib. If you want to manage locales I would suggest
using an attribute in the request or page context and not messing around
with the response.

Date: 2008-08-20 12:34
Sender: kennymacleod

Doesn't the servlet container just ignore calls to setLocale() once the
response has been committed? I'm not sure if this is violating the servlet
spec, or is just misleading.

Joda - Time

Tracker: Bugs

Comments ( 2 )

Attached File

No Files Currently Attached

Change

No changes have been made to this artifact.

About SourceForge

Find Software

Develop Software

Community

Help