Share

Open Virtual Machine Tools

Tracker: Tracker

5 Tools fail to build against GTK1 - ID: 2014338
Last Update: Settings changed ( rbeasley )

When trying to make both open-vm-tools-2008.07.01-102166 &
open-vm-tools-2008.06.20-100027 I get the following error, though
open-vm-tools-2008.06.03-96374 works fine:

Making all in vmware-user
make[1]: Entering directory
`/home/sduncan/downloads/open-vm-tools-2008.07.01-102166/vmware-user'
gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.07.01-102166\" -DPACKAGE_STRING=\"open-vm-tools\
2008.07.01-102166\"
-DPACKAGE_BUGREPORT=\"open-vm-tools-devel@lists.sourceforge.net\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.07.01-102166\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DDNET_IS_DUMBNET=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1
-DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1
-DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1
-DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1
-DHAVE_LSEEK=1 -I. -DUSING_AUTOCONF=1 -D_REENTRANT -I/usr/include
-DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU
-I/home/sduncan/downloads/open-vm-tools-2008.07.01-102166/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2
-I/usr/lib/glib/include -I../include -DRESOLUTION_X11 -g -O2 -Wall -Werror
-Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing
-Wno-unknown-pragmas -Wno-uninitialized -MT vmware-user.o -MD -MP -MF
.deps/vmware-user.Tpo -c -o vmware-user.o vmware-user.c
vmware-user.c:100: error: expected ')' before '*' token
vmware-user.c:985: error: expected ')' before '*' token
vmware-user.c: In function 'AcquireDisplayLock':
vmware-user.c:1081: error: 'GdkDisplay' undeclared (first use in this
function)
vmware-user.c:1081: error: (Each undeclared identifier is reported only
once
vmware-user.c:1081: error: for each function it appears in.)
vmware-user.c:1081: error: 'defaultDisplayGdk' undeclared (first use in
this function)
cc1: warnings being treated as errors
vmware-user.c:1089: warning: implicit declaration of function
'InitGdkWindow'
vmware-user.c:1099: warning: implicit declaration of function
'gdk_x11_display_get_xdisplay'
vmware-user.c:1099: warning: assignment makes pointer from integer without
a cast
make[1]: *** [vmware-user.o] Error 1
make[1]: Leaving directory
`/home/sduncan/downloads/open-vm-tools-2008.07.01-102166/vmware-user'
make: *** [all-recursive] Error 1


Stephen Duncan Jr ( jrduncans ) - 2008-07-09 17:03

5

Closed

None

Ryan Beasley

vmware-user

None

Public


Comments ( 6 )

Date: 2008-07-10 20:35
Sender: jrduncans


It builds now. Thanks.


Date: 2008-07-10 20:05
Sender: rbeasley


Okay, that's a separate but related issue, and has already been fixed
in-house by Ghais.

Relevant patch attached. It should apply cleanly against the latest
refresh.

Please give it a shot.
File Added: ovt-gtk_1_toolbox-toolbox-gtk.c.patch


Date: 2008-07-10 19:54
Sender: jrduncans


I get a new error now, further on:

gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.07.01-102166\" -DPACKAGE_STRING=\"open-vm-tools\
2008.07.01-102166\"
-DPACKAGE_BUGREPORT=\"open-vm-tools-devel@lists.sourceforge.net\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.07.01-102166\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DDNET_IS_DUMBNET=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1
-DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1
-DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1
-DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1
-DHAVE_LSEEK=1 -I. -DUSING_AUTOCONF=1 -D_REENTRANT -I/usr/include
-DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU
-I/home/sduncan/downloads/open-vm-tools-2008.07.01-102166/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2
-I/usr/lib/glib/include -g -O2 -Wall -Werror -Wno-pointer-sign
-Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas
-Wno-uninitialized -MT toolbox-gtk.o -MD -MP -MF .deps/toolbox-gtk.Tpo -c
-o toolbox-gtk.o toolbox-gtk.c
cc1: warnings being treated as errors
toolbox-gtk.c: In function 'ToolsMain_Create':
toolbox-gtk.c:565: warning: implicit declaration of function
'gtk_label_newl'
toolbox-gtk.c:565: warning: passing argument 3 of
'gtk_notebook_append_page' makes pointer from integer without a cast
make[1]: *** [toolbox-gtk.o] Error 1
make[1]: Leaving directory
`/home/sduncan/downloads/open-vm-tools-2008.07.01-102166/toolbox'
make: *** [all-recursive] Error 1



Date: 2008-07-10 18:32
Sender: rbeasley


Hi, Stephen,

Please accept my apology for mis-addressing you. :)


Date: 2008-07-10 18:30
Sender: rbeasley


Hi, Duncan,

Would you please give the attached patch a shot?

TIA!
File Added: ovt-vmware-user_gtk1_unhappy-vmware-user_vmware-user.c.patch


Date: 2008-07-09 18:12
Sender: rbeasley


D'oh. This is definitely a regression. GdkDisplay doesn't exist in
g[dt]k-1.2.

I'll try to get a fix back to you soon.

Thanks for the report.


Attached Files ( 2 )

Filename Description Download
ovt-vmware-user_gtk1_unhappy-vmware-user_vmware-user.c.patch [patch] Allow vmware-user to build against GTK1. Download
ovt-gtk_1_toolbox-toolbox-gtk.c.patch Fix toolbox-gtk build against GTK1. Download

Changes ( 16 )

Field Old Value Date By
status_id Open 2008-07-10 20:44 rbeasley
close_date - 2008-07-10 20:44 rbeasley
status_id Pending 2008-07-10 20:35 jrduncans
close_date 2008-07-10 20:05 2008-07-10 20:35 jrduncans
status_id Open 2008-07-10 20:05 rbeasley
close_date - 2008-07-10 20:05 rbeasley
summary vmware-user fails to build against GTK1 2008-07-10 20:05 rbeasley
File Added 284273: ovt-gtk_1_toolbox-toolbox-gtk.c.patch 2008-07-10 20:05 rbeasley
status_id Pending 2008-07-10 19:54 jrduncans
close_date 2008-07-10 18:30 2008-07-10 19:54 jrduncans
summary Can't Compile vmware-user.c 2008-07-10 18:32 rbeasley
close_date - 2008-07-10 18:30 rbeasley
status_id Open 2008-07-10 18:30 rbeasley
File Added 284268: ovt-vmware-user_gtk1_unhappy-vmware-user_vmware-user.c.patch 2008-07-10 18:30 rbeasley
category_id None 2008-07-09 18:12 rbeasley
assigned_to nobody 2008-07-09 18:12 rbeasley