Share

Zoomable Visual Transformation Machine

Tracker: Bugs

5 Metadata not being assign correctly if no <title> tags - ID: 1999082
Last Update: Settings changed ( epietrig )

If a SVG file is being imported and the <g> tags do not have <title> tags
associated with them, the context information will not be assigned to the
new Glyph. It this a requirement of inputted SVG files? If not, the patch
below should solve this problem by removing the check for 'title' tags.


greenfreak ( greenfreak ) - 2008-06-20 19:33

5

Closed

Fixed

Emmanuel Pietriga

zvtm

None

Public


Comments ( 5 )




Date: 2008-06-23 22:15
Sender: greenfreak


Yep, this works for my current test cases; it behaves as I expected. Feel
free to close this out and I'll submit another report if this becomes an
issue in the future. Thanks!


Date: 2008-06-23 21:20
Sender: epietrigProject Admin


It seems to work fine (in the sense that it does not break my ZGRViewer
test cases). I've committed a new version of SVGReader (not exactly your
patch, but should behave appropriately). In SVN since 20080623. In ZVTM
0.9.7-SNAPSHOT. Let me know if it works for you.


Date: 2008-06-23 19:21
Sender: epietrigProject Admin


It probably wouldn't break anything, and it would indeed be more general.
I'll fix this and see if it has any consequence on ZGRViewer. If it does
not, then I'll commit this to the trunk.



Date: 2008-06-23 18:47
Sender: greenfreak


Yes, that explicit check for the <title> tags is not allowing the 'id'
attr to be assigned to the Metadata when importing the SVG. I'm using a
custom SVG file that wraps different svg element types by using the <g>
tag; essentially grouping things like text, rect, and polygons. I need the
'id' attribute in the <g> tag in order to assign the Glyph owners
appropriately. I will have to include <title> tags in all of my <g> tags
to retrieve this data, unless you remove that explicit check. I removed
this on my end (see patch) and the data propagates correctly. I just
wasn't sure if you wanted to leave the check in place because of DOT
requirements or other requirements I'm not aware of. I didn't want to
break the ZGR Viewer. :)


Date: 2008-06-23 14:00
Sender: epietrigProject Admin


I don't think this is a requirement. The reason for this is probably that
there was no reason to create a context if no information had to be
propagated (lazy instantiation of context). Are there cases where
contextual information is not propagated in the current implementation?




Log in to comment.




Attached File ( 1 )

Filename Description Download
SVGReader.java.patch Download

Changes ( 15 )

Field Old Value Date By
close_date - 2008-06-24 04:48 epietrig
resolution_id Works For Me 2008-06-24 04:48 epietrig
status_id Open 2008-06-24 04:48 epietrig
status_id Closed 2008-06-23 22:15 greenfreak
close_date 2008-06-23 21:20 2008-06-23 22:15 greenfreak
resolution_id Fixed 2008-06-23 22:15 greenfreak
resolution_id None 2008-06-23 21:20 epietrig
status_id Open 2008-06-23 21:20 epietrig
close_date - 2008-06-23 21:20 epietrig
close_date 2008-06-23 14:11 2008-06-23 18:47 greenfreak
status_id Pending 2008-06-23 18:47 greenfreak
close_date - 2008-06-23 14:11 epietrig
status_id Open 2008-06-23 14:11 epietrig
assigned_to nobody 2008-06-23 14:00 epietrig
File Added 282039: SVGReader.java.patch 2008-06-20 19:33 greenfreak