Share

vinetto

Tracker: Bugs

5 some suggestions - ID: 1925009
Last Update: Tracker Item Submitted ( rsabet )

Very interesting solution - many thanks for your efforts.

May i suggest some things (i am playing with vinetto on Windows but without
cygwin)
And with just a few modifications it works almost perfect on plain
Windows:

1)
os.system("mkdir " + opts.outputdir + "/" + NUMBERED_THUMBS_DIR)

doesn't work, since mkdir ..., but pythons os.mkdir works just fine:
#os.system("mkdir " + opts.outputdir + "/" + NUMBERED_THUMBS_DIR)
s=os.path.join(opts.outputdir,NUMBERED_THUMBS_DIR)
if not os.path.exists(s):
os.mkdir(s)

2) instead of hardcoded paths that do not exist in plain Win you could use
relative paths to the directory where the files are extracted
#header = open("/usr/share/vinetto/header","rb").read()
#quantization = open("/usr/share/vinetto/quantization","rb").read()
#huffman = open("/usr/share/vinetto/huffman","rb").read()
header =
open(os.path.join(os.path.abspath('.'),"res/header"),"rb").read()
quantization =
open(os.path.join(os.path.abspath('.'),"res/quantization"),"rb").read()
huffman =
open(os.path.join(os.path.abspath('.'),"res/huffman"),"rb").read()

3) same issue as (2)
for ligne in
open(os.path.join(os.path.abspath('.'),"res/HtRepTemplate.html"),"r").readl
ines():

4) there is the issue with the html reports which use or do not use the
.thumbs directory, and as far as i have seen there is an option to create
symlinks ...

regards and keep up the good work
Ramin


R_S ( rsabet ) - 2008-03-25 10:01

5

Open

None

Nobody/Anonymous

None

v1.0 (example)

Public


Comments




Log in to comment.

No follow-up comments have been posted.

Attached File

No Files Currently Attached

Change

No changes have been made to this artifact.