Donate Share

Open Media Collectors Database

Tracker: Bugs

5 Small bug in FreeDB site plugin (?) - ID: 1886792
Last Update: Comment added ( jasonpell )

While reading the source of the FreeDB site plugin class (freedb.class.php)
(I'm creating a search plugin for eMusic.com), i noticed the following
piece of code (line 199)

$tracks = $this->parseTracks($entryBlock);
if(is_array($title_r))
{
$this->addItemAttribute('tracks', $tracks);
}

is it correct that you check if $title_r is an array while you are
processing the tracks? i guess it makes more sense if it would be
is_array($tracks), unless i missed something...


Jeroen Budts ( teranex ) - 2008-02-05 08:29

5

Closed

None

Jason Pell

None

1.5a3

Public


Comment ( 1 )

Date: 2008-02-05 12:12
Sender: jasonpellProject Admin


you did not miss anything - its a bug that would not normally ever be a
problem - as $title_r will always be an array - would only ever be a
problem if an item returned no tracks. I am applying your fix to both 1.0
and 1.5 svn.

Thanks for the bug fix

Cheers
Jason


Attached File

No Files Currently Attached

Changes ( 4 )

Field Old Value Date By
status_id Open 2008-02-05 12:12 jasonpell
artifact_group_id None 2008-02-05 12:12 jasonpell
assigned_to nobody 2008-02-05 12:12 jasonpell
close_date - 2008-02-05 12:12 jasonpell