WIDE-DHCPv6

Tracker: Bugs

5 Malformed OPTION_DOMAIN_LIST - ID: 1852869

Last Update: Comment added ( suzsuz )

Details:

If domain-name configuration end with '.'(period), encoded option will be
malformed.

Submitted:

Hirose ( yhirose ) - 2007-12-18 06:08

Priority:

Status:

Closed

Resolution:

Accepted

Assigned:

suz@kame.net

Category:

dhcp6s

Group:

None

Visibility:

Public

Comments ( 2 )

Date: 2008-05-01 04:16 Sender: suzsuz The proposed fix has been committed. (common.c rev 1.18)
Date: 2007-12-18 06:13 Sender: yhirose Because calculated length does not match encoded length. Index: common.c =================================================================== RCS file: /cvsroot/wide-dhcpv6/wide-dhcpv6/common.c,v retrieving revision 1.16 diff -u -r1.16 common.c --- common.c 6 Dec 2007 14:53:49 -0000 1.16 +++ common.c 18 Dec 2007 06:10:54 -0000 @@ -513,7 +513,7 @@ memcpy(cp, name, nlen); cp += nlen; } - if (copy_option(type, optlen, tmpbuf, p, optep, len) != 0) { + if (copy_option(type, cp - tmpbuf, tmpbuf, p, optep, len) != 0) { free(tmpbuf); return -1; }

Date: 2008-05-01 04:16
Sender: suzsuz

The proposed fix has been committed.
(common.c rev 1.18)

Date: 2007-12-18 06:13
Sender: yhirose

Because calculated length does not match encoded length.

Index: common.c
===================================================================
RCS file: /cvsroot/wide-dhcpv6/wide-dhcpv6/common.c,v
retrieving revision 1.16
diff -u -r1.16 common.c
--- common.c 6 Dec 2007 14:53:49 -0000 1.16
+++ common.c 18 Dec 2007 06:10:54 -0000
@@ -513,7 +513,7 @@
memcpy(cp, name, nlen);
cp += nlen;
}
- if (copy_option(type, optlen, tmpbuf, p, optep, len) != 0) {
+ if (copy_option(type, cp - tmpbuf, tmpbuf, p, optep, len) != 0) {
free(tmpbuf);
return -1;
}

Log in to comment.

Attached File

Changes ( 4 )

Field	Old Value	Date	By
status_id	Open	2008-05-01 04:16	suzsuz
resolution_id	None	2008-05-01 04:16	suzsuz
assigned_to	nobody	2008-05-01 04:16	suzsuz
close_date	-	2008-05-01 04:16	suzsuz

WIDE-DHCPv6

Tracker: Bugs

Comments ( 2 )

Log in to comment.

Attached File

No Files Currently Attached

Changes ( 4 )

About SourceForge

Find Software

Develop Software

Community

Help