Synfig Animation Studio

Tracker: Patches

5 multibyte support for text layer - ID: 1852208

Last Update: Comment added ( dooglus )

Details:

i recently stumbled upon synfig. amazing piece of software!

i needed german umlauts in the text layer, which was not possible with
synfig-0.61.07. created the attached patch. now it works fine.

i am not a c++ expert, maybe you should have a quick check on the patch. it
is pretty small anyway: 1 line is exchanged by 21 lines, 3 lines are
added -- in only 1 file. please doublecheck line 21:
(1) the "&(*iter)" thing. i did not know how to do that in a clean way in
c++.
(2) "text.end() - iter": not sure if this is the proper way to do it.
(3) not sure if the error/warning stuff is 100% correct.

Submitted:

Niki W. Waibel ( nikiwaibel ) - 2007-12-17 10:17

Priority:

Status:

Closed

Resolution:

Fixed

Assigned:

Nobody/Anonymous

Category:

None

Group:

None

Visibility:

Public

Comments ( 6 )

Date: 2008-01-01 18:45 Sender: dooglus Sure. It turned out that your most recent fix was added as part of adding multi-lingual support to synfig, which will appear in the next version.
Date: 2008-01-01 18:35 Sender: nikiwaibel dooglus, thank you. i don't have enough time to get and test the latest code. this is the reason why you see a version# with my patches. sorry for creating some misunderstandings here. people who compile and use the released version can have multibyte support with the 2 patches...
Date: 2008-01-01 16:01 Sender: dooglus That last comment was from me. Seems sf.net won't keep me logged in any more like it used to.
Date: 2008-01-01 16:00 Sender: nobody Logged In: NO Thanks for the patch Niki, but that setlocale() call has already been added to the code since the last release. When submitting patches for synfig, it's best to submit a patch against the current version of the code in subversion ( http://wiki.synfig.com/Subversion ) to avoid duplicating work. I just noticed that the call to setlocale() was conditional on gettext being available, which it needn't be, so I've changed that.
Date: 2008-01-01 01:53 Sender: nikiwaibel hmmm -- i reopened this issue... i found out that the synfig command does not set the locale when the program is started. attached a patch (synfig-0.61.07.nww.multibyte2.patch) that fixes it. (used only synfigstudio so far, which seems to set the locale correctly). File Added: synfig-0.61.07.nww.multibyte2.patch
Date: 2007-12-17 14:06 Sender: dooglus svn r1207

Log in to comment.

Attached Files ( 2 )

Filename	Description	Download
synfig-0.61.07.nww.multibyte.patch		Download
synfig-0.61.07.nww.multibyte2.patch	fixes locale setting in synfig command	Download

Changes ( 9 )

Field	Old Value	Date	By
status_id	Open	2008-01-01 16:01	dooglus
close_date	-	2008-01-01 16:01	dooglus
File Added	260333: synfig-0.61.07.nww.multibyte2.patch	2008-01-01 01:53	nikiwaibel
status_id	Closed	2008-01-01 01:53	nikiwaibel
close_date	2007-12-17 14:06	2008-01-01 01:53	nikiwaibel
resolution_id	None	2007-12-17 14:06	dooglus
status_id	Open	2007-12-17 14:06	dooglus
close_date	-	2007-12-17 14:06	dooglus
File Added	258862: synfig-0.61.07.nww.multibyte.patch	2007-12-17 10:17	nikiwaibel

Synfig Animation Studio

Tracker: Patches

Comments ( 6 )

Log in to comment.

Attached Files ( 2 )

Changes ( 9 )

About SourceForge

Find Software

Develop Software

Community

Help