iTerm.app

5 Underline not drawn with double width - ID: 1826697

Last Update: Comment added ( yfabian )

Details:

The attached patch fixes underlines drawn under double width characters
only having single widths.

Submitted:

Akinori MUSHA ( knu ) - 2007-11-06 09:54

Priority:

Status:

Closed

Resolution:

Fixed

Assigned:

Nobody/Anonymous

Category:

i18n

Group:

None

Visibility:

Public

Date: 2008-09-05 23:53 Sender: yfabian Fixed. Thanks!
Date: 2008-08-28 03:49 Sender: yfabian Thanks a lot, Akinori! I've merged your patch into our code.
Date: 2008-08-25 09:35 Sender: knu File upload does not work.. http://akinori.org/tmp/iterm_underline.png
Date: 2008-08-25 09:32 Sender: knu darn upload errors...
Date: 2008-08-25 09:30 Sender: knu Here's a screenshot. Would you please apply the patch?
Date: 2007-11-19 12:36 Sender: knu Hi, That is because with the current implementation underlined double width characters will look like this: WCWCWCWC (Suppose each "WC" is a wide character) - - - - (Suppose each "-" is a piece of underline for the above line) It is especially ugly when you mix single width and wide width characters. WCcWCWCcc - -- - -- What I expect is solid lines instead of dashed/broken lines. WCWCWCWC -------- WCcWCWCcc --------- Hope I make myself clear this time.
Date: 2007-11-19 05:37 Sender: yfabian Why should the underlines be drawn with double width?

Filename	Description	Download
iTerm-double-width-underline.patch	patch	Download

Field	Old Value	Date	By
status_id	Open	2008-09-05 23:53	yfabian
resolution_id	None	2008-09-05 23:53	yfabian
close_date	-	2008-09-05 23:53	yfabian
File Added	253017: iTerm-double-width-underline.patch	2007-11-06 09:54	knu