Share

UPX - a powerful executable packer

Tracker: Bugs

5 Complete error handling - ID: 1819028
Last Update: Comment added ( elfring )

I have noticed a few "FIXME" markers in your source code. I've missed one
in your member function "FileBase::sopen()". Would you like to call your
function "throwIOException()" if the call "open()" or "fstat()" failed?


Markus Elfring ( elfring ) - 2007-10-24 05:47

5

Closed

Fixed

Markus F.X.J. Oberhumer

None

None

Public


Comments ( 6 )




Date: 2008-01-02 21:26
Sender: elfring


Thanks.


Date: 2008-01-02 10:59
Sender: mfxProject Admin


Should be fixed in 3.02.


Date: 2007-11-08 10:32
Sender: elfring


None - Do you expect any open issues with C++ wrappers for C functions?


Date: 2007-11-06 01:23
Sender: mfxProject Admin


Checking for errors is of course good practice. Which other unchecked
function calls did you spot?



Date: 2007-10-30 15:47
Sender: elfring


I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?


Date: 2007-10-30 14:24
Sender: mfxProject Admin


Throwing exceptions is sopen() indeed looks like a good idea. This is
currently no real problem, though, as we will fail later in
read/write/seek/...


Log in to comment.




Attached File

No Files Currently Attached

Changes ( 6 )

Field Old Value Date By
status_id Pending 2008-01-02 21:26 elfring
close_date 2008-01-02 10:59 2008-01-02 21:26 elfring
status_id Open 2008-01-02 10:59 mfx
resolution_id None 2008-01-02 10:59 mfx
close_date - 2008-01-02 10:59 mfx
assigned_to nobody 2007-10-30 14:24 mfx