Pioneers

Fixed in svn 0.11.4 (1360)

I found the cause of the problem. If the connection was terminated before
the state machine was initialized, the CLOSE_EVENT would trigger the
assert, because route_event was getting (but not using) the current stack
function. I'll submit a patch which fixes the problem thoroughly, by not
using the current stack function when it doesn't exist (also for all other
events, where I didn't see the bug so far, but I'm not sure if it might be
possible there; if it was, it's fixed now. If not, nothing changed).

I can't find the problem so far, but in case someone else wants to look, I
attached some progress. The file starts with a patch adding some debugging
stuff. Then the end of a gdb log follows, where I started
pioneers-server-gtk --debug. It first receives a broken pipe, later the
assert is triggered. Because I took some time handling the broken pipe,
the clients are disconnected (because they didn't reply to the pings).
This does not happen without gdb, but doesn't change the rest of the
behaviour.

As input I used a script which repeatedly connects and chats (the exact
output can be seen from the log). It disconnects after 100 chats.
File Added: crashlog

It might also have to do with sending data before the server asked
anything. I'll look into it more.

One problem is fixed, but a problem still remains. Here's how to
reproduce it:
- Start a server for two players
- Start a graphical client and an AI
- Start a viewer and create a broken pipe with it (for example by
chatting, and disconnecting before the reply is sent).
- Start a new viewer.
- Disconnect this new viewer.
An assert is hit, namely:
** ERROR **: file common/state.c: line 630 (sm_current): assertion failed:
(sm->stack_ptr >= 0)

Fixed in svn 1341 (0.11.3)