Python Wikipedia Robot Framework

Tracker: Bugs

5 self.interwiki_text_separator & interwiki attop - ID: 1754881

Last Update: Settings changed ( xqt )

Details:

When interwiki links are added attop, the self.interwiki_text_separator
variable should be set to '' (instead of '\r\n\r\n').

The setting as it is now ('\r\n\r\n') causes empty lines to appear at the
top of the articles.

Alternatively this could be configurable per project (though I don't
believe any project would want their entries to begin with two empty
lines).

Submitted:

Tomasz Sienicki ( tsca ) - 2007-07-16 16:47

Priority:

Status:

Closed

Resolution:

Out of Date

Assigned:

Nobody/Anonymous

Category:

interwiki

Group:

None

Visibility:

Public

Comments ( 2 )

Date: 2009-10-17 15:58 Sender: xqt Possibly changed in r6172
Date: 2007-07-17 03:12 Sender: purodha These settings are imho not correctly object-oriented, which is wrong, or bad style, which should be changed. Imho, it is ok to have these settings be set per family, as it is currently done. But, they should be inherited by the language/wiki, which isn't currently so Finally any specific wiki project should be able to alter them individually, which is currently impossible. Also, the separator treatment is currently wrong. As it happens to be, separators get accidentally removed, since they are made up from a number of \r's and \n's, which get stripped anyway. If you alter the separator, this is no more the case, and interwiki.py / categories.py move all existing separators to one place, and add one or two new separators upon each invocation. This is imho highly undesirable. I suggest to correctly remove existing separators together with the categories / interwikies, when they are removed, and insert exactly one of them, when categories / interwikies are inserted, or reinserted.

Date: 2009-10-17 15:58
Sender: xqt

Possibly changed in r6172

Date: 2007-07-17 03:12
Sender: purodha

These settings are imho not correctly object-oriented, which is wrong, or
bad style, which should be changed.

Imho, it is ok to have these settings be set per family, as it is
currently done.
But, they should be inherited by the language/wiki, which isn't currently
so
Finally any specific wiki project should be able to alter them
individually, which is currently impossible.

Also, the separator treatment is currently wrong. As it happens to be,
separators get accidentally removed, since they are made up from a number
of \r's and \n's, which get stripped anyway. If you alter the separator,
this is no more the case, and interwiki.py / categories.py move all
existing separators to one place, and add one or two new separators upon
each invocation. This is imho highly undesirable.

I suggest to correctly remove existing separators together with the
categories / interwikies, when they are removed, and insert exactly one of
them, when categories / interwikies are inserted, or reinserted.

Attached File

Changes ( 4 )

Field	Old Value	Date	By
status_id	Open	2009-10-17 15:58	xqt
resolution_id	None	2009-10-17 15:58	xqt
allow_comments	1	2009-10-17 15:58	xqt
close_date	-	2009-10-17 15:58	xqt

Python Wikipedia Robot Framework

Tracker: Bugs

Comments ( 2 )

Attached File

No Files Currently Attached

Changes ( 4 )

About SourceForge

Find Software

Develop Software

Community

Help