any2dvd

Tracker: Bugs

5 free disk space check fails in some cases - ID: 1728036

Last Update: Comment added ( eliasp )

Details:

You use 'df -Tm' to determine available space for processing. This works
OK in most cases but fails in some, due to device name length.

I have a system that uses software raid, and the created raid device name
is too long, so 'df -Tm' prints the name on one line followed by the
details on a second line. This changes the number of fields from 7 to 6,
for the last line, and selects the percent used value for the 'size'.

I don't see anyplace where the extra 'Type' value is used so I removed the
'T' option and changed the awk command to print '$4' rather than '$5'.
This seems to work fine for getting disk size only.

You might want to consider testing for the number of fields in the last
line:

... | awk '{if($NF == 7) # it's one line
print $2
else
print $1}'`

in any2vob line 294.

Submitted:

Bob McGowan ( rmcgowan ) - 2007-05-30 04:27

Priority:

Status:

Open

Resolution:

None

Assigned:

Nobody/Anonymous

Category:

None

Group:

None

Visibility:

Public

Comments ( 2 )

Date: 2008-11-26 10:45 Sender: eliasp It is better using just the -P option for 'df'.... Solving the problems instead of working around them. Patch against any2vob from any2dvd-0.34 --- any2dvd-0.34.orig/any2vob 2008-11-26 11:38:02.000000000 +0100 +++ any2dvd-0.34/any2vob 2007-03-01 23:24:54.000000000 +0100 @@ -291,7 +291,7 @@ --preformat=yes) PREFORMAT_FRC="yes"; shift ;; --calc) shift; CALC="yes" ;; --workdir=) WORKDIR=`echo "$1" \| sed 's/--workdir=/ /' \| sed 's/^[ \t]//'` - FILESYS=`df -PTh "$WORKDIR" \| tail -n1 \| awk '{print $2}'` + FILESYS=`df -Th "$WORKDIR" \| tail -n1 \| awk '{print $2}'` if [ "$FILESYS" = "vfat" ]; then warn WARNING: Your workdir \'"$WORKDIR"\' resides on a FAT Windows partition echo -e "\e[33;01m Be aware that this may well cause problems as there is a 2GB filesize limit\e[m" @@ -984,13 +984,13 @@ echo fi fi - DISKSPACE_AVAIL_MB=`df -PTm "$WORKDIR" \| tail -n1 \| awk '{print $5}'` + DISKSPACE_AVAIL_MB=`df -Tm "$WORKDIR" \| tail -n1 \| awk '{print $5}'` DISKSPACE_AVAIL_GB=`perl -le "printf ('%.2f', $DISKSPACE_AVAIL_MB / 1024)"` DISKSPACE_NEEDED_MB=`perl -le "print int($TOTAL_SIZEMB * 2)"` DISKSPACE_NEEDED_GB=`perl -le "printf ('%.2f', $DISKSPACE_NEEDED_MB / 1024)"` [ "$ISO" != "no" ] && [ "$ANY2DVD" = "yes" ] && DISKSPACE_NEEDED_MB=`perl -le "print int($TOTAL_SIZEMB * 3)"` if [ "$DISKSPACE_NEEDED_MB" -ge "$DISKSPACE_AVAIL_MB" ]; then - errmsg WARNING: "Not enough diskspace available, $DISKSPACE_NEEDED_GB GB needed, but only $DISKSPACE_AVAIL_GBGB available on `df -PT "$WORKDIR" \| tail -n1 \| awk '{print $1}'`" + errmsg WARNING: "Not enough diskspace available, $DISKSPACE_NEEDED_GB GB needed, but only $DISKSPACE_AVAIL_GBGB available on `df -T "$WORKDIR" \| tail -n1 \| awk '{print $1}'`" echo -en " Are you sure you want to continue ? \033[1m(yes/no)\e[m " read continue [ "$continue" != "yes" ] && echo -e "\nENCODING ERROR" >> $VAR_DATAFILE && exit
Date: 2007-06-06 00:08 Sender: rickharris This was mentioned in Bug #1669892 but was auto-closed due to lack of feedback -> http://sourceforge.net/tracker/index.php?func=detail&aid=1669892&group_id=143060&atid=754969 Could you please test with 0.36 beta and report if it fixes the problem: http://mightylegends.org/downloads/any2vob-0.36_beta.sh http://mightylegends.org/downloads/any2dvd-0.36_beta.sh Thanks :)

Date: 2008-11-26 10:45
Sender: eliasp

It is better using just the -P option for 'df'....
Solving the problems instead of working around them.

Patch against any2vob from any2dvd-0.34

--- any2dvd-0.34.orig/any2vob 2008-11-26 11:38:02.000000000 +0100
+++ any2dvd-0.34/any2vob 2007-03-01 23:24:54.000000000 +0100
@@ -291,7 +291,7 @@
--preformat=yes) PREFORMAT_FRC="yes"; shift ;;
--calc) shift; CALC="yes" ;;
--workdir=*) WORKDIR=`echo "$1" | sed 's/--workdir=/ /' |
sed 's/^[ \t]*//'`
- FILESYS=`df -PTh "$WORKDIR" | tail -n1 |
awk '{print $2}'`
+ FILESYS=`df -Th "$WORKDIR" | tail -n1 |
awk '{print $2}'`
if [ "$FILESYS" = "vfat" ]; then
warn WARNING: Your workdir
\'"$WORKDIR"\' resides on a FAT Windows partition
echo -e "\e[33;01m Be aware that
this may well cause problems as there is a 2GB filesize limit\e[m"
@@ -984,13 +984,13 @@
echo
fi
fi
- DISKSPACE_AVAIL_MB=`df -PTm "$WORKDIR" | tail -n1 | awk '{print
$5}'`
+ DISKSPACE_AVAIL_MB=`df -Tm "$WORKDIR" | tail -n1 | awk '{print
$5}'`
DISKSPACE_AVAIL_GB=`perl -le "printf ('%.2f', $DISKSPACE_AVAIL_MB
/ 1024)"`
DISKSPACE_NEEDED_MB=`perl -le "print int($TOTAL_SIZEMB * 2)"`
DISKSPACE_NEEDED_GB=`perl -le "printf ('%.2f',
$DISKSPACE_NEEDED_MB / 1024)"`
[ "$ISO" != "no" ] && [ "$ANY2DVD" = "yes" ] &&
DISKSPACE_NEEDED_MB=`perl -le "print int($TOTAL_SIZEMB * 3)"`
if [ "$DISKSPACE_NEEDED_MB" -ge "$DISKSPACE_AVAIL_MB" ]; then
- errmsg WARNING: "Not enough diskspace available,
$DISKSPACE_NEEDED_GB GB needed, but only $DISKSPACE_AVAIL_GBGB available on
`df -PT "$WORKDIR" | tail -n1 | awk '{print $1}'`"
+ errmsg WARNING: "Not enough diskspace available,
$DISKSPACE_NEEDED_GB GB needed, but only $DISKSPACE_AVAIL_GBGB available on
`df -T "$WORKDIR" | tail -n1 | awk '{print $1}'`"
echo -en " Are you sure you want to continue ?
\033[1m(yes/no)\e[m "
read continue
[ "$continue" != "yes" ] && echo -e "\nENCODING ERROR" >>
$VAR_DATAFILE && exit

Date: 2007-06-06 00:08
Sender: rickharris

This was mentioned in Bug #1669892 but was auto-closed due to lack of
feedback ->
http://sourceforge.net/tracker/index.php?func=detail&aid=1669892&group_id=143060&atid=754969

Could you please test with 0.36 beta and report if it fixes the problem:
http://mightylegends.org/downloads/any2vob-0.36_beta.sh
http://mightylegends.org/downloads/any2dvd-0.36_beta.sh

Thanks :)

any2dvd

Tracker: Bugs

Comments ( 2 )

Log in to comment.

Attached File

No Files Currently Attached

Change

No changes have been made to this artifact.

About SourceForge

Find Software

Develop Software

Community

Help