Share

TwoLAME

Tracker: Bugs

5 Fix problems with inline in gcc-4.3 - ID: 1691689
Last Update: Settings changed ( nhumfrey )

Package: twolame
Version: 0.3.9-1
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3. Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning. In C99 the meaning of "inline"
changed, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31389
A patch for this problem is below.

Automatic build of twolame_0.3.9-1 on coconut0 by sbuild/ia64 0.49
...
cc -DHAVE_CONFIG_H -I. -I. -I../build -I ../build/ -g -Wall -O2 -std=c99
-Wunused -Wall -O3 -c crc.c -fPIC -DPIC -o .libs/crc.o
bitbuffer.h:44: warning: inline function 'buffer_putbits' declared but
never defined
bitbuffer.h:44: warning: inline function 'buffer_putbits' declared but
never defined
...
mkdir .libs
cc -I../build/ -I../libtwolame/ -g -Wall -O2 -std=c99 -Wunused -Wall -O3 -o
.libs/twolame frontend.o /usr/lib/libsndfile.so /usr/lib/libFLAC.so
../libtwolame/.libs/libtwolame.so -lm
../libtwolame/.libs/libtwolame.so: undefined reference to `buffer_putbits'
collect2: ld returned 1 exit status
make[2]: *** [twolame] Error 1

--- libtwolame/common.h~ 2007-03-30 20:07:53.000000000 +0000
+++ libtwolame/common.h 2007-03-30 20:08:10.000000000 +0000
@@ -33,7 +33,7 @@
#define NO_DLL_INLINE
#else
#include "config.h"
-#define NO_DLL_INLINE inline
+#define NO_DLL_INLINE extern inline
#endif


Nicholas Humfrey ( nhumfrey ) - 2007-03-30 22:38

5

Closed

Accepted

Nicholas Humfrey

libtwolame

None

Public


Comment ( 1 )

Date: 2007-07-01 21:05
Sender: nhumfreyProject Admin


this is now applied in trunk.


Attached File

No Files Currently Attached

Changes ( 4 )

Field Old Value Date By
status_id Open 2007-07-01 21:05 nhumfrey
resolution_id None 2007-07-01 21:05 nhumfrey
assigned_to nobody 2007-07-01 21:05 nhumfrey
close_date - 2007-07-01 21:05 nhumfrey