ZynAddSubFX

Tracker: Patches

5 split Master::mutex into initMutex and processMutex - ID: 1651753

Last Update: Settings changed ( fundamental )

Details:

Master::initMutex is used when we expect longer timeouts during Instruments
loading or bankswitching.
jackprocess() uses pthread_mutex_trylock() on it and
outputs silence, if initMutex isn't available

Master::processMutex is used to protect note/parameter events from actual
soundgeneration.
jackprocess() unconditionally requests it, so there are far less crackles.

Patch is against cvs head of yesterday.
It contains a Makefile.inc change switching zyn to jackd + alsa - midi
mode.

jackd-midi is commented out as it didn't compile here.

PADnoteParameters::applyparameters()'s "bool lockmutex" argument is deleted
as its always called with true.

Submitted:

Karsten ( fzu ) - 2007-02-04 15:13

Priority:

Status:

Closed

Resolution:

Out of Date

Assigned:

Nobody/Anonymous

Category:

None

Group:

None

Visibility:

Public

Comments ( 2 )

Date: 2007-02-04 22:47 Sender: geraldf2 Hello, Compilation fails if LINUX_AUDIOOUT=OSS_AND_JACK in the Makefile.inc, giving the following errors: main.C: In function ‘void* thread2(void*)’: main.C:149: error: ‘class Master’ has no member named ‘mutex’ main.C:151: error: ‘class Master’ has no member named ‘mutex’ After replacing 'mutex' with 'processMutex' on these two lines it seems to compile and run ok.
Date: 2007-02-04 18:46 Sender: evermind same patch but with jackmidi 2 additonal patches: - optional jackmidi - fix jackmidi breakage http://evermind.ev.funpic.de/zyn-patches/

Date: 2007-02-04 22:47
Sender: geraldf2

Hello,

Compilation fails if LINUX_AUDIOOUT=OSS_AND_JACK in the Makefile.inc,
giving the following errors:
main.C: In function ‘void* thread2(void*)’:
main.C:149: error: ‘class Master’ has no member named ‘mutex’
main.C:151: error: ‘class Master’ has no member named ‘mutex’

After replacing 'mutex' with 'processMutex' on these two lines it seems to
compile and run ok.

Date: 2007-02-04 18:46
Sender: evermind

same patch but with jackmidi
2 additonal patches:
- optional jackmidi
- fix jackmidi breakage
http://evermind.ev.funpic.de/zyn-patches/

Log in to comment.

Attached File ( 1 )

Filename	Description	Download
zynaddsubfx_jackdfix.diff	patch lit Master::mutex into initMutex and processMutex	Download

Changes ( 4 )

Field	Old Value	Date	By
status_id	Open	2009-09-02 12:43	fundamental
resolution_id	None	2009-09-02 12:43	fundamental
close_date	-	2009-09-02 12:43	fundamental
File Added	214437: zynaddsubfx_jackdfix.diff	2007-02-04 15:13	fzu

ZynAddSubFX

Tracker: Patches

Comments ( 2 )

Log in to comment.

Attached File ( 1 )

Changes ( 4 )

About SourceForge

Find Software

Develop Software

Community

Help