GemRB Game Engine

Tracker: Patches

5 [Core] Fix compilation for MSVC [1/3] - ID: 1646493

Last Update: Comment added ( sf-robot )

Details:

Hi!

After a long time I decided to try compiling GemRB again on MSVC. I noticed
some small problems, which are easily fixable. Although I could have
committed them right away, I think it's better to post them here for review
first.

Patch 1/3:

win32def.h should include <cstdlib>. This is assumed in some other files
which don't explicitly include <cstdio> themself, so I thought the easiest
fix is to simply include it here.

Submitted:

Michael Drueing ( doc_wagon ) - 2007-01-28 17:06

Priority:

Status:

Closed

Resolution:

Works For Me

Assigned:

Laszlo Toth

Category:

Engine Source

Group:

None

Visibility:

Public

Comments ( 4 )

Date: 2007-03-14 02:20 Sender: sf-robot This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).
Date: 2007-02-27 22:34 Sender: avenger_teambg Ok, the code compiles for me on msvc 7 and 6 too, so i don't see the need for this patch.
Date: 2007-01-31 22:06 Sender: doc_wagon okay, obviously I meant <cstdlib> instead of <cstdio>. I'm using MSVC8 (MSVC 2005). I might take another look and put the "#include <cstdlib>" into the .cpp files instead of a global header, I guess that's the better solution.
Date: 2007-01-31 21:19 Sender: avenger_teambg I'm not entirely sure about this, i'll have to check if this won't break other msvc compilations. I did not need this for compiling on msvc6.0 or msvc7.2 What version you got?

Attached File ( 1 )

Filename	Description	Download
win32_include_cstdlib.patch	patch for compilation on MSVC, 1 of 3	Download

Changes ( 7 )

Field	Old Value	Date	By
close_date	2007-02-27 22:34	2007-03-14 02:20	sf-robot
status_id	Pending	2007-03-14 02:20	sf-robot
resolution_id	None	2007-02-27 22:34	avenger_teambg
close_date	-	2007-02-27 22:34	avenger_teambg
assigned_to	nobody	2007-02-27 22:34	avenger_teambg
status_id	Open	2007-02-27 22:34	avenger_teambg
File Added	213468: win32_include_cstdlib.patch	2007-01-28 17:06	doc_wagon

GemRB Game Engine

Tracker: Patches

Comments ( 4 )

Attached File ( 1 )

Changes ( 7 )

About SourceForge

Find Software

Develop Software

Community

Help