Share

Mobile Sudoku

Tracker: Bugs

5 Error in screen size calculation - ID: 1614434
Last Update: Settings changed ( cowboy_bob )

When calculating the screen size for painting the board, MobileSudoku takes
into account only the width of the screen and then assumes that the height
is less than or equal to the width. In landscape devices (such as the Nokia
E61) this is not true, so parts of the top and bottom rows of the board are
not drawn (or drawn "outside the screen"). It would be better to use the
lesser of the width and the height for this calculation.


Mario Camou ( mcamou ) - 2006-12-13 02:02

5

Closed

Fixed

Nobody/Anonymous

None

None

Public


Comments ( 2 )




Date: 2006-12-19 19:18
Sender: cowboy_bobProject Admin


You're absolutely right. I'm currently in the process of getting beta 2
together after fixing it to work on 128x128 pixel screens, and I'll make
sure this fix is in there.


Date: 2006-12-13 02:25
Sender: mcamou


Looking a bit at the code I think this might be fixed in GameBoard.java.
Change line 255 to:

if (width >= Sudoku.SCREEN_SIZE_LARGE && height >=
Sudoku.SCREEN_SIZE_LARGE)

and the same thing in line 260. I haven't had a chance to test it since I
haven't set up the J2ME environment in my laptop but I think that might
work.


Log in to comment.

Attached File

No Files Currently Attached

Changes ( 3 )

Field Old Value Date By
status_id Open 2006-12-19 19:23 cowboy_bob
resolution_id None 2006-12-19 19:23 cowboy_bob
close_date - 2006-12-19 19:23 cowboy_bob