Heritrix: Internet Archive Web Crawler

Tracker: Bugs

7 HeritrixProtocolSocketFactory synchronization causes delays - ID: 1538489

Last Update: Comment added ( karl-ia )

Details:

A Stack commit in May synchronized
HeritrixProtocolSocketFactory.createSocket() -- which
in my test crawls has had the result that no new
sockets can be created during the long connect timeouts
when contacting absent servers.

I don't beleive this synchronization is necessary; the
method does not appear to use any shared objects that
need to be protected. (The ServerCache's key
mutators/accessors are synchronized.)

Submitted:

Gordon Mohr ( gojomo ) - 2006-08-11 07:42

Priority:

Status:

Closed

Resolution:

Fixed

Assigned:

Michael Stack

Category:

Protocols

Group:

1.10.0

Visibility:

Public

Comments ( 3 )

Date: 2007-03-14 01:10 Sender: karl-ia This issue is now discussed in the new JIRA tracker at http://webteam.archive.org/jira/browse/HER-605 -- please add further comments at that location.
Date: 2006-08-18 23:43 Sender: gojomo Logged In: YES user_id=144912 Stack approved change. Delays no longer evident. Closing as fixed.
Date: 2006-08-11 07:44 Sender: gojomo Logged In: YES user_id=144912 For now, I'm removing the 'synchronized'. Commit commment: Fix for [ 1538489 ] HeritrixProtocolSocketFactory synchronization causes delays * HeritrixProtocolSocketFactory.java remove believed-unnecessary synchronization causing crawl pauses Passing to Stack for review.

Attached File

Changes ( 6 )

Field	Old Value	Date	By
status_id	Open	2006-08-18 23:43	gojomo
resolution_id	None	2006-08-18 23:43	gojomo
close_date	-	2006-08-18 23:43	gojomo
category_id	None	2006-08-11 07:44	gojomo
artifact_group_id	None	2006-08-11 07:44	gojomo
assigned_to	nobody	2006-08-11 07:44	gojomo

Heritrix: Internet Archive Web Crawler

Tracker: Bugs

Comments ( 3 )

Attached File

No Files Currently Attached

Changes ( 6 )

About SourceForge

Find Software

Develop Software

Community

Help