Donate Share December 2003: Project of the Month

PhpGedView

Tracker: Bug Reports

5 User Admin, account approval box always checked - ID: 1487570
Last Update: Comment added ( canajun2eh )

If we navigate to a new registration, open edit, we
find that the ACCT APPROVED box is already checked. To
keep the account from being "auto authorized", the
admin must uncheck the box prior to exitting the user.

We believe that to have the box "prechecked" as
approved, it is incorrectly programmed.

Stephen


Stephen Arnold ( okbigkid ) - 2006-05-12 17:44

5

Closed

Fixed

Gerry Kroll

None

None

Public


Comments ( 7 )

Date: 2006-05-18 23:45
Sender: canajun2eh

Logged In: YES
user_id=1198414

Fixed in recent release of beta8


Date: 2006-05-14 10:16
Sender: canajun2eh

Logged In: YES
user_id=1198414

The updated code is in the newly restored Future Branch CVS,
and should make it into the beta8 release.


Date: 2006-05-13 14:53
Sender: okbigkidSourceForge.net DonorProject Donor

Logged In: YES
user_id=1061833

FIXED for us with attached file, TNX
-stephen


Date: 2006-05-13 10:47
Sender: canajun2eh

Logged In: YES
user_id=1198414

Stephen:
Please try the attached useradmin.php.

The problem you reported also existed for the self-verified
field. PGV was testing the wrong value for these two
fields, and because of that, it was always setting the two
boxes to "checked".


Date: 2006-05-13 00:11
Sender: okbigkidSourceForge.net DonorProject Donor

Logged In: YES
user_id=1061833

No misunderstanding. We tacitly knew that PGV was trying to
be "helpful" but virtually every action in PGV is deliberate
resultant of actions by the Admin, and in this case it is
not. Upon approving an account, the Admin already has to
make other changes to the account:
1) assign the INDI account to the user if listed in the
GEDfile, and
2) determine the level of control for the user (access,
edit, admin, etc), and
3) make any notes about the user in the notes section.

We just think that the act of approving a user should also
be a deliberate action, not one assumed by PGV as the reason
the Admin is accessing the account.
-Stephen


Date: 2006-05-13 00:03
Sender: canajun2eh

Logged In: YES
user_id=1198414

Stephen:
I think this may be a misunderstanding on your part.

PGV is trying to be helpful here. The usual reason for an
Admin to look at a new user's account is to approve it.
That's why the "Approved by Admin" checkbox is automatically
checked when the Admin looks at the account.

Until the Admin has looked at the account, it is definitely
NOT "approved by admin".

Are you sure you want the Admin to explicitly approve the
new user, instead of just accessing the account? Remember
that the Admin still has to save the changes.


Date: 2006-05-12 22:36
Sender: canajun2eh

Logged In: YES
user_id=1198414

Stephen:
You are correct. This will be fixed as soon as CVS is up.

Please send an e-mail to John, asking him to hold off with
release of beta8 until this is fixed. (it's a trivial change).


Attached File ( 1 )

Filename Description Download
useradmin.zip zip file containing useradmin.php for 4.0beta8 Download

Changes ( 6 )

Field Old Value Date By
status_id Open 2006-05-18 23:45 canajun2eh
close_date - 2006-05-18 23:45 canajun2eh
summary User Admin, account approval box 2006-05-13 10:47 canajun2eh
File Added 177793: useradmin.zip 2006-05-13 10:47 canajun2eh
resolution_id None 2006-05-13 10:47 canajun2eh
assigned_to nobody 2006-05-12 22:36 canajun2eh