JFreeChart

I found it odd that createTextBlock replaced the last three characters of
the last word with "..." rather than placing "..." separately if there is
enough room. It's more of a JCommon fix than a JFreechart fix

Here is how I solved it.. It wraps normally on all but the last line,
otherwise it tries to fit as much as possible plus the "..."





Index: jcommon-1.0.15/source/org/jfree/text/TextUtilities.java
===================================================================
--- jcommon-1.0.15/source/org/jfree/text/TextUtilities.java (revision 28)
+++ jcommon-1.0.15/source/org/jfree/text/TextUtilities.java (working copy)
@@ -70,6 +70,10 @@
import java.text.BreakIterator;

import org.jfree.base.BaseBoot;
+import org.jfree.text.TextBlock;
+import org.jfree.text.TextFragment;
+import org.jfree.text.TextLine;
+import org.jfree.text.TextMeasurer;
import org.jfree.ui.TextAnchor;
import org.jfree.util.Log;
import org.jfree.util.LogContext;
@@ -224,7 +228,7 @@
public static TextBlock createTextBlock(final String text, final Font
font,
final Paint paint, final float maxWidth, final int maxLines,
final TextMeasurer measurer) {
-
+
final TextBlock result = new TextBlock();
final BreakIterator iterator = BreakIterator.getLineInstance();
iterator.setText(text);
@@ -232,33 +236,52 @@
int lines = 0;
final int length = text.length();
while (current < length && lines < maxLines) {
- final int next = nextLineBreak(text, current, maxWidth,
iterator,
+ int next = nextLineBreak(text, current, maxWidth, iterator,
measurer);
if (next == BreakIterator.DONE) {
result.addLine(text.substring(current), font, paint);
return result;
}
- result.addLine(text.substring(current, next), font, paint);
+
+ // If we're on the last line add as much as we can so we
don't wrap
+ if(lines == maxLines - 1)
+ {
+ // Keep adding words until we go past the maxWidth (and keep
it!)
+ while(next != BreakIterator.DONE &&
measurer.getStringWidth(text, current, next) < maxWidth)
+ next = iterator.next();
+
+ if(next == BreakIterator.DONE)
+ next = text.length();
+ }
+
+ result.addLine(text.substring(current, next), font, paint);
lines++;
current = next;
- while (current < text.length()&& text.charAt(current) ==
'\n') {
+ while (current < text.length()&& text.charAt(current) ==
'\n')
current++;
- }
}
- if (current < length) {
- final TextLine lastLine = result.getLastLine();
- final TextFragment lastFragment =
lastLine.getLastTextFragment();
- final String oldStr = lastFragment.getText();
- String newStr = "...";
- if (oldStr.length() > 3) {
- newStr = oldStr.substring(0, oldStr.length() - 3) +
"...";
- }
-
- lastLine.removeFragment(lastFragment);
- final TextFragment newFragment = new TextFragment(newStr,
- lastFragment.getFont(), lastFragment.getPaint());
- lastLine.addFragment(newFragment);
+
+
+ // Handle the last line and add "..."s as needed
+ final TextLine lastLine = result.getLastLine();
+ final TextFragment lastFragment = lastLine.getLastTextFragment();
+ final String oldStr = lastFragment.getText();
+
+ // Try to see how many characters exactly we can fit from the line
+ int offset = 4;
+ while(measurer.getStringWidth(oldStr.substring(0, offset), 0,
offset) < maxWidth)
+ ++offset;
+
+ if(offset != oldStr.length())
+ {
+ String newStr = oldStr.substring(0, offset - 3) + "...";
+
+ lastLine.removeFragment(lastFragment);
+ final TextFragment newFragment = new TextFragment(newStr,
lastFragment.getFont(), lastFragment.getPaint());
+ lastLine.addFragment(newFragment);
}
+
+
return result;
}

Unfortunately, this defect has been reproduced with the latest JFreeChart
library (1.0.12) using java version 1.6.0_07

Can some body tell me if this bug has been fixed or not. If yes then which
version. - Thanks

Logged In: YES
user_id=85900

Just wondering what the status is on this.

Logged In: YES
user_id=112975

Thanks for the report - I'll take a look.