Tracker: Current Stable Branch (1.4)

5 Trash Folder Exclusion On Courier - ID: 1354393
Last Update: Settings changed ( tokul )

There is an error in folders.php for Courier IMAP. The
scripts says to exclude a folder from the list if its name
is 'inbox.trash' but it doesn't get excluded because the
name on this type of IMAP would be 'INBOX.Trash', but
it is above the strtolower function, so a match isn't
made.

Please let me know if you have any questions.

Michael Card


Michael Card ( greetingsc ) - 2005-11-11 20:09

5

Closed

Fixed

Tomas Kuliavas

None

None

Public


Comments ( 9 )

Date: 2006-08-14 13:36
Sender: tokul

Logged In: YES
user_id=225877

cvs log -r1.147 src/folders.php
cvs diff -u -r 1.146 -r 1.147 src/folders.php

I like to break things only in HEAD.


Date: 2006-08-14 13:16
Sender: kinkProject AdminAccepting Donations

Logged In: YES
user_id=285765

Didn't this get fixed recently?


Date: 2006-07-06 14:45
Sender: tokul

Logged In: YES
user_id=225877

SquirrelMail has code that should add special handling to
trash folder on Courier. There is an error in folder name
case and code is not active. But Courier documentation does
not have any information that explains why INBOX.Trash is
special.

If courier is used, SquirrelMail does not allow to store
folders in Trash. I think user can have trash subfolders in
courier.

Issues are low priority. In order to fix these issues some
changes are needed in conf.pl and src/folders.php



Date: 2006-07-06 12:52
Sender: kinkProject AdminAccepting Donations

Logged In: YES
user_id=285765

What's exactly the status of this?


Date: 2005-11-20 17:48
Sender: greetingsc

Logged In: YES
user_id=1376538

According to the SM docs for Courier, delete folder should
be set to true? If this is wrong I will change in on my
setup then retest.

Michael Card


Date: 2005-11-20 09:41
Sender: tokul

Logged In: YES
user_id=225877

After folder is deleted, interface displays 'refresh left
folder list' link. If you don't refresh the listing and try
using outdated left folder listing, it will cause folder
errors on any imap server.

If I remove special handling of Trash folder for courier, I
am able to store folders in Trash, purge link removes Trash
subfolders without any error messages. I am using courier
imap 3.0.8, standard courier preset and set $delete_folder
variable to false.

Please provide steps how to reproduce error, if left folder
listing is up to date.

You can try deleting folder with name that already exists in
trashfolder. You get folder deletion error, but issue is not
specific to courier.



Date: 2005-11-19 20:12
Sender: greetingsc

Logged In: YES
user_id=1376538

There is already a workaround for this, if it is going to
stay it should work correctly. I believe one of the
reasons for it would be if you empty the trash, it deletes
those folders, and then the left folder list gives an
error because it thinks those folders are still in the
folder list. You should be able to replicate this problem.

Let me know your questions thoughts. I would agree that it
should either be taken out or left in there, but left it
should be corrected.

Michael Card


Date: 2005-11-18 07:24
Sender: tokul

Logged In: YES
user_id=225877

Please provide explanation why courier-imap can't store
folders in INBOX.Trash. Without such information I'll remove
all SquirrelMail INBOX.Trash workarounds specific to courier
and forward all related bug reports to courier.

INBOX.Trash folder is not reported as \NoInferiors on
courier-imap 3.0.8 and 4.0.6. SquirrelMail can store folders
in INBOX.Trash.



Date: 2005-11-12 13:08
Sender: tokul

Logged In: YES
user_id=225877

can you provide more information about this issue. Which
courier version can't store folders in INBOX.Trash?




Attached Files ( 2 )

Filename Description Download
courier-trash.diff 1.5.1cvs patch Download
stable.diff 1.4.6cvs patch Download

Changes ( 8 )

Field Old Value Date By
close_date - 2006-08-15 17:43 tokul
status_id Open 2006-08-15 17:43 tokul
resolution_id None 2006-08-15 17:43 tokul
category_id Folders 2006-08-14 13:36 tokul
data_type 423679 2006-08-14 13:36 tokul
File Added 156923: stable.diff 2005-11-20 09:42 tokul
File Added 156922: courier-trash.diff 2005-11-20 09:41 tokul
assigned_to nobody 2005-11-18 07:24 tokul