Tracker: Current Stable Branch (1.4)

5 Fatal error: Only variables can be passed by reference - ID: 1237160
Last Update: Comment added ( tokul )

* Fatal error: Only variables can be passed by
reference in
/usr/local/apache2/htdocs/squirrelmail/functions/imap_messages.php
on line 480

After upgrading from PHP4 to PHP5.1, my Squirrelmail
now sends this message login, when I click on INBOX, or
when I click on "sent." Everything else continues to work.


Nobody/Anonymous ( nobody ) - 2005-07-12 21:52:55 PDT

5

Closed

Fixed

Tomas Kuliavas

None

None

Public


Comments ( 9 )

Date: 2005-07-20 02:24:03 PDT
Sender: tokul

Logged In: YES
user_id=225877

Fixed in 1.5.1cvs and 1.4.6cvs

$this error in functions/imap_mailbox.php still happens in
devel branch, but we have other bug report (#1190160) for it.


Date: 2005-07-14 09:19:46 PDT
Sender: nobody

Logged In: NO

Tokul,

Thanks once again. I really appreciate it.

Mike


Date: 2005-07-14 07:44:30 PDT
Sender: tokul

Logged In: YES
user_id=225877

same issue.

SquirrelMail 1.4.5 uses array_shift() function with function
all as argument in four places.

src/configtest.php
plugins/listcommands/setup.php
class/mime/Rfc822Header.php
functions/imap_messages.php

Attached patch for all four calls + some small fixes in
src/configtest.php and src/search.php.

It should be fixed in 1.4.6cvs, but we'll try fixing devel
first.


Date: 2005-07-13 14:09:04 PDT
Sender: nobody

Logged In: NO

But now when I try to open the message (now that I can see
the messages in the inbox), I get the following error:

Fatal error: Only variables can be passed by reference in
/usr/local/apache2/htdocs/squirrelmail/class/mime/Rfc822Header.class.php
on line 509

Mike


Date: 2005-07-13 14:05:39 PDT
Sender: nobody

Logged In: NO

Hi Tokul,

Thanks so much.

Mike


Date: 2005-07-13 13:40:55 PDT
Sender: nobody

Logged In: NO

I am using Squirrelmail version 1.4.5. I tried installing
the CVS, but I had the notorious "&This" error.

Thanks,

Mike


Date: 2005-07-13 07:56:46 PDT
Sender: tokul

Logged In: YES
user_id=225877

it is enough to divide split() and array_shift() into two
calls.


Date: 2005-07-13 07:05:33 PDT
Sender: tokul

Logged In: YES
user_id=225877

Please provide more details about used squirrelmail version
or Id tag of imap_messages.php file

try reproducing your error in 1.5.1cvs or 1.4.5rc1


Date: 2005-07-13 07:05:02 PDT
Sender: janglissProject AdminAccepting Donations

Logged In: YES
user_id=620333

We need to know what version of SquirrelMail you are using.


Attached Files ( 2 )

Filename Description Download
imap_messages.php.diff Download
squirrelmail-stable.diff second patch. I think all array_shift()s are fixed Download

Changes ( 7 )

Field Old Value Date By
status_id Open 2005-07-20 02:24:03 PDT tokul
close_date - 2005-07-20 02:24:03 PDT tokul
resolution_id None 2005-07-20 02:24:03 PDT tokul
data_type 423679 2005-07-14 11:00:14 PDT tokul
assigned_to nobody 2005-07-14 07:47:17 PDT tokul
File Added 142050: squirrelmail-stable.diff 2005-07-14 07:44:36 PDT tokul
File Added 141940: imap_messages.php.diff 2005-07-13 07:49:24 PDT tokul