It was a bit dodgy how I had to do it; the list object wasn't
previously passed to Utils.maketext(), so I had to find all the
callers of maketext and add the list object to the call params.
Mostly, the change is in Utils.py, but there's a slight touch to
a lot of other files.
I'm also assuming that anyone who matters is going through
maketext(); I hope that's true....although I just noticed
that it's not strictly true, so this patch is incomplete.
Arrrr.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
However: all the files which don't use maketext are already list-specific,
so I'm back to thinking this is a complete patch. Anything in templates/ which
is not already in lists/<listname> can be put there after this patch is applied,
and the version in lists/<listname> will override the default version.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I like the ability to add list-specific files that override more general ones, but I'm a little nervous about apply this patch so late in the game. Also, I'm unsure whether it's best to pass the listpath into maketext().
I'd like to see a more general mechanism that has a hierarchy of files, with the most specific being selected: site, virtual-host, list-style, list-specific, language, maybe user choice.
Postponing until after 2.0 final.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
None
It was a bit dodgy how I had to do it; the list object wasn't
previously passed to Utils.maketext(), so I had to find all the
callers of maketext and add the list object to the call params.
Mostly, the change is in Utils.py, but there's a slight touch to
a lot of other files.
I'm also assuming that anyone who matters is going through
maketext(); I hope that's true....although I just noticed
that it's not strictly true, so this patch is incomplete.
Arrrr.
However: all the files which don't use maketext are already list-specific,
so I'm back to thinking this is a complete patch. Anything in templates/ which
is not already in lists/<listname> can be put there after this patch is applied,
and the version in lists/<listname> will override the default version.
Revised to latest CVS; include bin/ and cron/
programs that I missed the first time
Updated to 2.0beta5; changed to pass "mlist._full_path" rather than the whole
mlist object (data abstraction).
I like the ability to add list-specific files that override more general ones, but I'm a little nervous about apply this patch so late in the game. Also, I'm unsure whether it's best to pass the listpath into maketext().
I'd like to see a more general mechanism that has a hierarchy of files, with the most specific being selected: site, virtual-host, list-style, list-specific, language, maybe user choice.
Postponing until after 2.0 final.
Updated for 2.0final. Note: it appears that approve.txt
is a dead file, so changing it will not make anything
about Mailman change at the moment.